[lilyshen0722]

Follow-up to CodeRabbit's note on #3276. The forbidden-reload test there revoked successfully, so the revoke error and the held confirm were already clear before the 403 reload. It would have passed with either clear removed.

The new test fails the revoke so both stay up, loses access (a 403 reload), then gets it back (a clean reload). It checks that the list returns with no alert and no held confirm. A new auth token recreates the api client and reruns the load, the way a session change would.

Reverse-verified: removing setRevokeError('') or setConfirmGrantId(null) from the 403 branch fails it. V2AgentRuntimeGrants: 29 of 29 pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_015AKgpMD6Qh13f7fj6mbGT3

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Team-Commonly/commonly
• Branch: launch/grants-403-test
• File: .coderabbit.yaml
• Commit: 6a456ae
• Layers: Repository YAML
• Review profile: QUIET
• Plan: Advanced
• Run ID: c1a8afd8-4bb9-4569-8364-6ba4139edecf

Commits

Reviewing files that changed from the base of the PR and between 95ee27c and 6a456ae.

Files selected for processing: 1

• frontend/src/v2/__tests__/V2AgentRuntimeGrants.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.

Walkthrough

This change adds a regression test for connector-grant state across failed revocation, a 403 reload, and restored access after a token change.

Changes: Connector grant state

Layer / File(s)	Summary
Grant state reset coverage frontend/src/v2/__tests__/V2AgentRuntimeGrants.test.tsx	The test checks that a failed revoke error and confirmation do not remain after a 403 reload and later successful reload. It also checks that the restored Revoke control is enabled.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

• Team-Commonly/commonly#3248: Introduced the connector-grants UI and its load, revoke, error, and confirmation states.
• Team-Commonly/commonly#3272: Changed grants-load 403 handling to clear prior load state.
• Team-Commonly/commonly#2527: Introduced the agent runtime and connector-grants component, including grant loading and revoke states.

Merge Risk: Minimal · up to 6a456

No actionable merge-blocking risk was identified in the regression test.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly identifies the new grants test and the pending revoke error and confirmation behavior across a 403 reload.
Description check		The description directly explains the test scenario, the expected state clearing, and the reported test validation.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

[lilyshen0722]

Review at 6a456ae, tests only.

• It reaches the 403 branch. A new token rebuilds useV2Api's headers and then get, api and load, which reruns the effect. The "Owner and admins only" assertion confirms the 403 path ran.
• It fails without each clear. Removing setRevokeError('') brings the "Could not revoke the grant." alert back. Removing setConfirmGrantId(null) brings "Yes, revoke it" back. Both checked on a copy, with the original restored and checksum-matched.
• It isn't flaky. Three repeated runs pass, and the full file passes, 29 of 29. Every await is a findBy*. beforeEach resets the axios mocks, so nothing leaks into later tests.

GATE: PASS