Skip to content

docs(ax): a status message and a gate that each read the wrong thing (entries 91, 92) - #3291

Merged
lilyshen0722 merged 2 commits into
mainfrom
cto/ax-91-92
Nov 2, 2026
Merged

lilyshen0722 merged 2 commits into
mainfrom
cto/ax-91-92

Conversation

@lilyshen0722

Copy link
Copy Markdown
Contributor

This PR adds two agent-experience audit entries, one for each of today's connector and entitlement fixes. #3286 and #3287 are both live on prod as of 2026-11-02 00:45Z.

Docs only. No code changes.

🤖 Generated with Claude Code

https://claude.ai/code/session_015AKgpQ2pr6xRMhN5mcfoHF

…ad the wrong thing

91: "upstream no longer lists X" named a vendor removal the check cannot
see; a connection's tools/list follows its owner's consent (#3286).
92: the cloud-entitlement gate read the install's host label before the
runtime type that dispatch actually reads (#3287, now live).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015AKgpQ2pr6xRMhN5mcfoHF
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 52d7844 and 7fc5829.

Files selected for processing: 1
  • docs/development/agent-experience-audit.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

Walkthrough

The audit file adds two entries. One documents tool-list drift handling. The other documents cloud-runtime classification by runtime type and host value.

Changes: Tool-list drift audit

Layer / File(s) Summary
Record tool-list drift behavior
docs/development/agent-experience-audit.md
Entry 91 records that a connection’s tools/list may omit tools because of consent or scope. It documents the revised tool_unavailable detail and that absent tools do not create drift cards.

Runtime classification audit

Layer / File(s) Summary
Record runtime classification behavior
docs/development/agent-experience-audit.md
Entry 92 records the isCloudRuntime classification for the listed runtime types and host values.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Merge Risk: Minimal · up to 7fc58

These documentation updates do not change runtime behavior and are ready to merge.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title names a docs-only change adding audit entries 91 and 92 for the hosted-MCP status message and the isCloudRuntime gate, which matches the changeset. It is specific and states the main change.…
Description check Passed The description is related to the changeset. It explains the two audit entries (91 and 92), the connector and entitlement fixes in #3286 and #3287, and states that the change is docs only with no code…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names a docs-only change adding audit entries 91 and 92 for the hosted-MCP status message and the isCloudRuntime gate, which matches the changeset. It is specific and states the main change. It is a little dense and uses a figurative phrase ("read the wrong thing"), but it is related to the change and not vague.

Full details: Description check

Explanation

The description is related to the changeset. It explains the two audit entries (91 and 92), the connector and entitlement fixes in #3286 and #3287, and states that the change is docs only with no code changes. This matches the single modified file, docs/development/agent-experience-audit.md.

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

…entry consent as inferred

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015AKgpQ2pr6xRMhN5mcfoHF

@lilyshen0722 lilyshen0722 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HEAD: 7fc5829 — GATE: PASS

This is the one review round for this change, a quick review by a fresh subagent at effort medium (docs only, Tier 0).

  • It checked every factual claim against origin/main and cited lines: the reworded tool_unavailable detail at hostedMcpEntryService.ts:338-342, the drift filter on tool_drift only at hostedMcpDriftAlertService.ts:96, isCloudRuntime's order before and after 2c9542b, the install route copying config.runtime as given, and inProcessInstallationFrom never reading host.
  • It found no names, handles or infrastructure identifiers, and found that entry 92 describes a class of bug, not a recipe.
  • Both clarity points are taken in 7fc5829: which types host: 'byo' still affects (only codex flips), and that the Sentry Triage consent is inferred rather than recorded.

GATE: PASS

@lilyshen0722
lilyshen0722 added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit 4d50502 Nov 2, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant