[lilyshen0722]

Playwright on main has failed one test since c1af20e (#3297): e2e/auth.spec.ts › "login with wrong password shows error" waits for .v2-login__error, and #3297 retired that div in favour of V2AuthNotice.

V2AuthNotice renders .v2-login__notice with role="alert" for a failure and role="status" for a confirmation. The spec now waits for .v2-login__notice[role="alert"], so a status row can't pass for an error.

No other e2e selector points at a class that is gone from frontend/src (each v2-login__* class the specs use was checked against main).

Proof: this PR's own "Playwright Tests" run. Main's runs at c1af20e, 8289c04 and 4f73fb5 are the red baseline, all failing this one test (13 passed, 1 failed).

🤖 Generated with Claude Code

https://claude.ai/code/session_015AKgpQ2pr6xRMhN5mcfoHF

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Team-Commonly/commonly
• Branch: cto/e2e-login-notice
• File: .coderabbit.yaml
• Commit: b1f8c66
• Layers: Repository YAML
• Review profile: QUIET
• Plan: Advanced
• Run ID: c63b6bd7-e290-428c-8e48-55b6c867fb52

Commits

Reviewing files that changed from the base of the PR and between 4f73fb5 and b1f8c66.

Files selected for processing: 1

• e2e/auth.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

Walkthrough

The wrong-password end-to-end test now checks for a visible alert in the .v2-login__notice row instead of checking for .v2-login__error.

Changes: Login alert test

Layer / File(s)	Summary
Verify login failure alert e2e/auth.spec.ts	The test checks that .v2-login__notice[role="alert"] is visible for a wrong-password login. Its comments distinguish failure alerts from confirmation statuses.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

• Team-Commonly/commonly#3292: Changes V2Login to show sign-in failures in an alert at the top of the card.
• Team-Commonly/commonly#3297: Adds V2AuthNotice and assigns role="alert" to failure notices.

Merge Risk: Minimal · up to b1f8c

The narrowly scoped test update correctly distinguishes login failures from confirmation notices and is ready to merge.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title states the main change: the wrong-password login e2e test now waits for the auth notice alert. The raw summary confirms the test was changed from checking the retired .v2-login__error elemen…
Description check		The description explains the change. It says the wrong-password spec waited for .v2-login__error, which was retired in #3297 in favour of V2AuthNotice. It says the spec now waits for .v2-login__notice…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title states the main change: the wrong-password login e2e test now waits for the auth notice alert. The raw summary confirms the test was changed from checking the retired .v2-login__error element to checking the .v2-login__notice row for an alert. The title uses the test(e2e) prefix and names the affected behaviour, so it is specific and accurate.

Full details: Description check

Explanation

The description explains the change. It says the wrong-password spec waited for .v2-login__error, which was retired in #3297 in favour of V2AuthNotice. It says the spec now waits for .v2-login__notice[role="alert"] so a status row cannot pass as an error. It also cites a Playwright run as proof and notes the other selectors were checked against main. It is related to the changeset.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

[lilyshen0722]

HEAD: b1f8c66 — GATE: PASS

One review round (D218), Tier 0 test change, reviewed by a Haiku subagent reading the code at this head:

• V2Login.tsx:90-91 renders V2AuthNotice once errorMessage is set, which the submit catch (:56-57) sets. V2AuthNotice.tsx:19 emits class="v2-login__notice" with role={kind}, and kind defaults to alert. v2.css has no hide rule for the row.
• No false pass: only V2AuthNotice produces .v2-login__notice, and on /v2/login it renders only after a failure.
• No other e2e selector in this change's scope points at a removed class. The reviewer also found pre-existing stale selectors in e2e/reviewer-journey.spec.ts, which this PR doesn't touch; those are for a separate fix.

GATE: PASS