You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: 560f9ab4-4ee4-4af2-aa64-92b8df8f9ae8
📥 Commits
Reviewing files that changed from the base of the PR and between 7d1eb79 and e068b14.
📒 Files selected for processing: 1
packages/core/src/consts/errorCode.ts
💤 Files with no reviewable changes: 1
packages/core/src/consts/errorCode.ts
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Walkthrough
오류 코드 카탈로그에서 폐기된 토너먼트 오류 코드 3개와 해당 메시지 및 상수를 제거했습니다. 다른 토너먼트 오류 코드 항목은 유지했습니다.
Changes: 토너먼트 오류 코드 카탈로그
Layer / File(s)
Summary
폐기된 코드와 메시지 제거 packages/core/src/consts/errorCode.ts
ERROR_MESSAGE_MAP에서 TOURNAMENT-024, TOURNAMENT-029, TOURNAMENT-031 메시지를 삭제했습니다. ERROR_CODE에서 대응하는 상수 3개를 삭제했습니다. TOURNAMENT-025~028 및 TOURNAMENT-030 항목은 유지했습니다.
The catalog is aligned with the reported server code removal, with no identified issue requiring a fix before merge.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
제목은 서버에서 폐기된 토너먼트 에러 코드를 카탈로그에서 제거하는 주요 변경 사항을 정확하게 요약합니다.
Linked Issues check
활성 직접 연결 이슈 #741은TOURNAMENT-024, TOURNAMENT-029, TOURNAMENT-031의 메시지 3개와 상수 3개를 packages/core/src/consts/errorCode.ts에서 제거하도록 요구합니다. 변경 diff는 ERROR_MESSAGE_MAP에서 세 키를 제거하고 ERROR_CODE에서 대응…
Out of Scope Changes check
변경은 packages/core/src/consts/errorCode.ts의 이슈 대상 에러 코드 제거로만 구성됩니다. diff에는 메시지 3개와 상수 3개의 삭제만 있으며, #741과 연결되지 않은 구현 변경은 확인되지 않습니다.
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check
Explanation
활성 직접 연결 이슈 #741은TOURNAMENT-024, TOURNAMENT-029, TOURNAMENT-031의 메시지 3개와 상수 3개를 packages/core/src/consts/errorCode.ts에서 제거하도록 요구합니다. 변경 diff는 ERROR_MESSAGE_MAP에서 세 키를 제거하고 ERROR_CODE에서 대응하는 세 상수를 제거합니다. TOURNAMENT-032는 유지되어 이슈의 별도 처리 범위도 보존됩니다.
Full details: Docstring Coverage
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
✨ Finishing Touches
📝 Generate docstrings
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 요약
작업 세부 내용
배경
서버 TeamPiKi/core#1191(CLONE 잔재 정리 4-1단계)에서 아래 세 코드를 결번 처리했습니다. CLONE 제거(TeamPiKi/core#1027) 이후 서버에서 던지는 곳이 0곳이 된 코드들입니다. 카탈로그의 원본이 서버 API 문서라 같이 맞춥니다.
TOURNAMENT-024TOURNAMENT_CLONED_CANNOT_SHARE_PLAY_LINKTOURNAMENT-029TOURNAMENT_ALREADY_CLONEDTOURNAMENT-031TOURNAMENT_CLONED_CANNOT_VIEW_GROUP_RESULT변경
packages/core/src/consts/errorCode.tsERROR_MESSAGE_MAP에서 문구 3개 제거ERROR_CODE에서 상수 3개 제거영향
확인
@piki/core·piki-web·piki-app타입 검사·lint 통과후속
TOURNAMENT-032·038은 토너먼트 CLONE 껍데기와 리다이렉트 제거 (4-2단계) core#1189(4-2단계) 머지 후 별도로 정리합니다스크린샷
없음 (UI 변화 없음)
연관 이슈
closes #741
Summary by CodeRabbit