Skip to content

chore: cover output-flag help (COD-507) - #13

Merged
shivros merged 1 commit into
mainfrom
runner/COD-507-clap-help-evidence
Sep 19, 2026
Merged

shivros merged 1 commit into
mainfrom
runner/COD-507-clap-help-evidence

Conversation

@shivros

@shivros shivros commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a compiled-Clap regression for list-records --help and zero-parameter status --help in the existing output-flag fixture.
  • Assert DisplayHelp, each exact output flag, and its rendered user-visible description.
  • Preserve request isolation and existing fixture freshness/determinism coverage; no production, generated-fixture, or public-contract change.

Verification

cargo test -p hydra-codegen --test codegen          # 50 passed
cargo build --all-targets                            # passed
cargo test --all-targets                             # passed (50 codegen, 14 Notes surface, 6 security-scan)
cargo clippy --all-targets -- -D warnings            # passed
cargo fmt --all -- --check                           # passed
examples/notes: hydra-codegen check                  # generated artifacts current
examples/security-scan: hydra-codegen check          # generated artifacts current
creed diff                                           # passed
git diff --check                                     # passed

Scope

Linear: COD-507

The diff is limited to crates/hydra-codegen/tests/codegen.rs.

@shivros

shivros commented Sep 19, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Automated Review Panel

Reviewer A — GPT-5.6 Terra (OpenAI Codex)

Classification: APPROVE

  • The change fulfills COD-507: it exercises the compiled FixtureCli parser for list-records --help and zero-parameter status --help.
  • It verifies ErrorKind::DisplayHelp, renders each returned help payload, and checks the relevant exact long flag plus its visible help description.
  • Existing supplied-value rejection, request isolation, fixture freshness, and byte-deterministic generation coverage remain intact.
  • No production, fixture, generated-artifact, release, or public-contract change was introduced.

Reviewer B — Gemini 3 Flash (OpenRouter)

Classification: APPROVE

  • Confirms that both CLI-only flags (--include-cursor and --verbose) are exercised through the compiled generated Clap surface and that the stable substring assertions avoid width-sensitive snapshots.
  • Confirms correct DisplayHelp handling and rendered-help inspection, including Clap's visible terminal-punctuation behavior.
  • No correctness, compatibility, concurrency, or convention violation was identified.

Both reviewers found no blocking or major issue. Local verification is recorded in the PR body.

@shivros
shivros marked this pull request as ready for review September 19, 2026 01:35
@shivros

shivros commented Sep 19, 2026

Copy link
Copy Markdown
Contributor Author

Auto-Merge Gate

Confidence: 0.96

COD-507 is a narrow, test-only regression for generated Clap help. The one-file diff exercises both requested real parser help paths, asserts DisplayHelp, and verifies the exact declared flag names and rendered descriptions. No runtime, generated artifact, public API, credential, deployment, or release scope is changed.

Checks observed: GitHub CI Test and Creed context drift succeeded. Independent gate verification passed: cargo test -p hydra-codegen --test codegen (50 passed).

No unresolved blocking review or Linear manual-review marker was found. Squash merge is appropriate.

@shivros
shivros merged commit abb1c64 into main Sep 19, 2026
2 checks passed
@shivros
shivros deleted the runner/COD-507-clap-help-evidence branch September 19, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant