Repository navigation
Conversation
Collaborator
|
The PR is still in draft status, cannot be merged |
ch-z-hc
marked this pull request as ready for review
October 14, 2026 08:17
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
For
throw "connection token expired", bothbsk consoleandbsk evaluatereport onlyUncaughtand lose the actual reason. Chrome sends that reason inexception.value, notexception.description. The same loss affects thrown booleans and null.Real isolated Chrome captures confirm both the
Runtime.exceptionThrownevents andRuntime.evaluateexception replies. Regression tests feed those shapes through the actual handlers: five console cases and three evaluate cases fail on their original implementations; numeric-description controls already pass.Fix
For console, reuse the existing
remoteObjectToText()conversion before extracting the first line (one product line). For evaluate, move its existing value fallback ahead of the generic header. No new serializer or abstraction. Existing Error descriptions, fallback when the value is absent, stack/location handling, truncation and buffering remain unchanged.Six console cases cover strings, multiline strings, zero, false, null and undefined. Four evaluate cases cover strings, false, null and the numeric-description control. The evaluate regressions were added as a follow-up to this same exception-message fix.
Validation
vitest run --maxWorkers=2: 2592 passed, 233 existing conditional skips after the evaluate follow-up. No assertions, timeouts or skip conditions were changed.The Chrome capture verifies browser event payloads, not an installed-extension/CLI end-to-end session. Rust and opt-in browser suites were not run. Implemented and tested with Codex assistance; no independent human review is claimed.