Skip to content

fix: honor OCTOP_HOME for the setup default expert - #1925

Open
jay23606 wants to merge 3 commits into
TencentCloud:developfrom
jay23606:fix/1913-octop-home
Open

jay23606 wants to merge 3 commits into
TencentCloud:developfrom
jay23606:fix/1913-octop-home

Conversation

@jay23606

Copy link
Copy Markdown

Summary

When setup created the default general-assistant, its local backend used the host drive root even when OCTOP_HOME was configured on another drive. Use the configured Octop home for the default expert when present, while preserving an explicit workspace policy root and the existing fallback when OCTOP_HOME is unset.

Closes #1913

Target branch

  • Base is develop (feature / fix — default)
  • Base is main (release/* or hotfix/* only)

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Refactor / chore
  • Release / hotfix

Test plan

  • Added/updated tests
  • Updated CHANGELOG.md
  • make all passes locally (GNU make is unavailable in this Windows environment; backend checks were run directly)

Regression gate: the new test fails on two clean develop worktrees and passes on two clean fix worktrees. The focused setup/default-agent tests pass (9 passed). Ruff checks and formatting pass; strict mypy reports no issues across 570 source files.

The full local Windows suite reported 4,443 passed, 199 skipped, and 12 failed. I reran the affected tests on unchanged develop; the same 12 failures reproduce there (Windows bash shim behavior, native process cleanup, and /proc path handling).

@jay23606
jay23606 force-pushed the fix/1913-octop-home branch from 65c2c15 to 7e7e0c7 Compare October 15, 2026 17:07

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant