Repository navigation
fix(plugins): ask Bangumi for the response group that carries ratings - #949
Open
lihongyuan99 wants to merge 1 commit into
Open
lihongyuan99 wants to merge 1 commit into
lihongyuan99 wants to merge 1 commit into
Conversation
lihongyuan99
force-pushed
the
fix/movie-search-rating-response-group
branch
5 times, most recently
from
September 29, 2026 23:20
e957432 to
fd0d4ba
Compare
lihongyuan99
force-pushed
the
fix/movie-search-rating-response-group
branch
5 times, most recently
from
October 5, 2026 23:13
5ec503e to
41a908f
Compare
lihongyuan99
force-pushed
the
fix/movie-search-rating-response-group
branch
3 times, most recently
from
October 14, 2026 23:18
7e6ccfc to
f030aac
Compare
search_movie sent responseGroup=small, whose payload has no `rating` key at
all, so the `rating` -> `score` branch never ran and every card line rendered
an empty score while ui/index.js still renders `评分 ${row.score}`.
lihongyuan99
force-pushed
the
fix/movie-search-rating-response-group
branch
from
October 15, 2026 23:15
f030aac to
b6763df
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
search_movieasked Bangumi forresponseGroup=small, and that payload does not contain aratingfield at all — so the score was alwaysNone, the card's rating line rendered empty, and the text summary printed—for every hit.src/octop/infra/agents/plugins/bundled/movie-search/main.py:28("responseGroup": "small").main.py:45-48readsrow["score"]and otherwiserating["score"]whenratingis a dict. Withsmallneither key is present, so that branch is dead code.bundled/movie-search/ui/index.js:40→row.score != null ? \评分 ${row.score}` : "") and the text summary (main.py:77→({r['score'] or '—'})`).Verified against the live API (same endpoint, same UA,
keyword=葬花,type=2):responseGroupratingsmall(current)air_date, air_weekday, id, images, name, name_cn, summary, type, urlcommonsmalllarge…, collection, eps, eps_count, rank, rating, …{"total": 12391, "count": {…}, "score": 7.5}The fix is the one token that makes the existing parser and the existing card work: request
large. End-to-end after the change, the real tool call now returns葬送のフリーレン ~トークの魔法~ (8.3)instead of(—).Target branch
develop(feature / fix — default)main(release/*orhotfix/*only)Type of change
Test plan
Added
tests/unit/test_movie_search_plugin.py, following the offline pattern already used bytests/unit/test_hot_topics_plugin.py(importlibload ofbundled/movie-search/main.py+ afake
httpx.Client). The fake mirrors bgm.tv's contract — it only includesratingwhen therequest asks for the
largegroup — so the test asserts the user-visible outcome (a scorereaches the payload and the text) rather than the literal parameter.
Re-measured after rebasing onto
develop@4667bd7bby flipping the token back tosmall:pytest -q tests/unit/test_movie_search_plugin.py->1 failed(AssertionErrorat thescore == 7.5check)1 failed, 6 passedpytest -q tests/unit/test_movie_search_plugin.py->1 passedtests/unit/test_hot_topics_plugin.py tests/unit/test_bundled_plugins_layout.py->7 passedruff check src tests->All checks passed!ruff format --check src tests->1081 files already formattedmypy src/octop->Success: no issues found in 530 source filespytest -q -m "not live" -n 6->3848 passed, 17 skipped, 0 failedin 220s, against3847 passed, 17 skipped, 0 failedmeasured on the base commitdevelop@4667bd7b(the +1 is this PR's new test)tests/livewas not run; no model API key or PostgreSQL was neededChecklist
CHANGELOG.md(if user-facing)Rebased onto
develop@ded7adddon 2026-09-30.1.0.2b4and1.0.2b5both shipped since the previous base, and each release commit folded the whole## [Unreleased]list into a version block, which emptied that section ondevelop— it is this branch's only conflict. The resolution keepsdevelop'sCHANGELOG.mdverbatim and re-inserts this PR's single bullet under a fresh### 修复; the rest of the patch is unchanged.Everything below was re-measured on
develop@ded7addd. Backend gates were run by hand, as the equivalents of the CI steps (make lint/make typecheck/make test);make allwas not used because this clone has nodashboard/node_modules.uv run pytest -q tests/unit/test_movie_search_plugin.py->1 failed in 5.05s1 passed in 1.42suv run ruff check src tests->All checks passed!;uv run ruff format --check src tests->1112 files already formatteduv run mypy src/octop->Success: no issues found in 543 source filesuv run pytest -q -m "not live" -n 6-> 3954 passed, 17 skipped, 1 failed in 216.68s, against 3953 passed, 17 skipped, 1 failed in 225.23s measured on the unmodified base commit in the same virtualenv. The single failure in both runs istests/unit/test_plugin_manager.py::test_install_plugin_importing_legacy_harness_agent:legacy_imports.ensure_legacy_harness_agent_alias()deliberately leaves a realharness_agentdistribution alone, and this local venv has an out-of-lockorcakit-harness-agentinstalled, so the alias assertion cannot hold here. It is pre-existing on the base, not a case this PR adds, and it is green in CI, which installs strictly fromuv.lock(thePython 3.12quality job issuccesson both this branch's pre- and post-rebase heads).tests/livewas not run; no model API key, PostgreSQL or Docker was needed.Rebased onto
develop@83b2ae2e7(2026-10-03).Four commits landed on
developsince this branch's previous base (a02e3e18e): LDAP directory login (#1123), propagating exhausted model retries as failures (#1012), and two dashboard fixes (#1429, #1241) — each appended a bullet to## [Unreleased], soCHANGELOG.mdis this PR's only conflict. The resolution keepsdevelop'sCHANGELOG.mdverbatim and re-inserts this PR's single line into the existing### 修复list:git diff origin/develop 46cf8c7d3 -- CHANGELOG.mdis+1/-0, andgit diff c2c9419bc7 46cf8c7d32over every non-CHANGELOG file of the PR is empty, i.e. the code you already reviewed is byte-identical.Re-measured on the new base with the same commands and the same virtualenv as the Test plan above:
ruff check src tests→All checks passed!ruff format --check src tests→1134 files already formattedmypy src/octop→Success: no issues found in 551 source filespytest -q tests/unit/test_movie_search_plugin.py→1 passed in 1.61spytest -q -m "not live" -n 3→ 1 failed, 4133 passed, 17 skipped, 13 warnings in 423.92s (0:07:03) (three branches measured concurrently, so the wall time is inflated), against 4132 passed, 17 skipped, 1 failed in 218.55s measured on the unmodified base83b2ae2e7in this same virtualenv: +1 cases against the base, which are exactly this PR's. The single failure in both runs is the pre-existing local artifacttests/unit/test_plugin_manager.py::test_install_plugin_importing_legacy_harness_agent— this venv has an out-of-lockorcakit-harness-agentdistribution installed, and that test deliberately leaves a realharness_agentpackage alone, so its alias assertion cannot hold here. It is red on the untouched base too and green in CI, which installs strictly fromuv.lock.2026-10-06 —
CHANGELOG.mdre-aligned withdevelop. A rebase of this branch had re-introduced other PRs' release-note bullets into the released## [1.0.2b6]block, so this PR's diff carried those foreign lines instead of only its own.CHANGELOG.mdis nowdevelop's file verbatim plus this PR's single bullet under## [Unreleased]→### 修复:git diff --numstat 75c274aef 41a908f68 -- CHANGELOG.md→1\t0\tCHANGELOG.mdgit diff --name-only 5ec503e1d 41a908f68→CHANGELOG.mdonly, so every code and test file is byte-identical to the head thatPython 3.12andWindows / Python 3.12both reported success on;the commands and counts under Test plan therefore still describe this diff.
CHANGELOG.mdat75c274aefis identical to today'sdeveloptip, so this does not need a fresh rebase.Rebased onto
develop@97d6e7ff4(2026-10-12); head41a908f68->f8d801ad5.CHANGELOG.mdis again this branch's only conflict, and the resolution keepsdevelop's fileverbatim and re-inserts only this PR's own bullet under its matching
###subsection — checkedmechanically: the diff against the new base is
1 added / 0 deletedinCHANGELOG.mdand byte-identical (hunk headers aside) for 2 code/test file(s) before and after the
rebase. Gates re-run by hand on the new head (
make allstill does not apply — nodashboard/node_modulesin this clone; the venv is created per worktree so/Users/macos/Documents/Qoder/octop-pr-mining/repos/wt-r-949/src/octop/__init__.pyis this branch's own code):1 passed in 20.25s4628 passed, 26 skipped, 17 warnings in 421.90s (0:07:01), againstdevelop@97d6e7ff4measured in the same venv: 4627 passed, 26 skipped, 0 failedAll checks passed!;1180 files already formatted;Success: no issues found in 570 source filesRebased onto
develop@87a8d52c2(2026-10-14);headf8d801ad5->7e6ccfcaa.CHANGELOG.mdis again the only conflict.develop's file is kept verbatim and this PR's ownbullet is re-inserted into the current
## [Unreleased]list, which is now flat (no###subsections), so the diff against the new base is
1 added / 0 deletedthere and the2 code/test file(s) are byte-identical before and after (hunk headers aside) — checked
mechanically, not by eye. Gates re-run by hand on the new head (
make allstill does not apply:no
dashboard/node_modulesin this clone; the venv belongs to this worktree, so/Users/macos/Documents/Qoder/octop-pr-mining/repos/wt-r-949/src/octop/__init__.pyis this branch's own code):RC ruff=0 format=0 mypy=0 targeted=0 full=01 passed in 5.98s4680 passed, 26 skipped, 41 warnings in 235.53s (0:03:55), againstdevelop@87a8d52c2measured in the same environment today: 4679 passed, 26 skipped, 0 failedAll checks passed!;1186 files already formatted;Success: no issues found in 571 source filesRebased onto
develop@99e479a6b(2026-10-16); headf030aac99->b6763df09.CHANGELOG.mdwas again the only conflict:develop's file is kept verbatim and this PR's own bullet is re-inserted under its matching###subsection of the current## [Unreleased]block, so the diff against the new base is1 added / 0 deletedthere and the2code/test file(s) are byte-identical before and after the rebase (checked mechanically on the patch hash, not by eye). Gates re-run by hand on the new head (make allstill does not apply — nodashboard/node_modulesin this clone; the venv belongs to this worktree, so the checkout under test is this branch's own code):RC ruff=0 format=0 mypy=0 targeted=0 full=01 passed in 3.97s4781 passed, 32 skipped, 41 warnings in 470.17s (0:07:50), againstdevelop@99e479a6bmeasured today in its own per-worktree venv on the same machine: 4780 passed, 32 skipped, 0 failed in 495.68sAll checks passed!;1204 files already formatted;Success: no issues found in 581 source files