Repository navigation
Remove static from namespace-scope function templates - #99
Open
lucascolley wants to merge 1 commit into
Open
lucascolley wants to merge 1 commit into
lucascolley wants to merge 1 commit into
Conversation
Namespace-scope `static` in a header gives each translation unit its own internal-linkage copy, which triggers clang's -Wunused-template in TUs that don't use them. Function templates don't need `static` to avoid ODR violations. Fixes Tessil#98
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Namespace-scope
staticin a header gives each translation unit its own internal-linkage copy, which triggers clang's-Wunused-templatein TUs that don't use them. Function templates don't needstaticto avoid ODR violations.Fixes #98
FYI @wjakob I'm hitting this on the PR to use nanobind in SciPy at scipy/scipy#26108
Fix drafted with claude code