Skip to content

Keep Antigravity background-task handoffs active while Core replays them - #1385

Merged
Th0rgal merged 1 commit into
masterfrom
fix/agy-background-handoff-active
Oct 28, 2026
Merged

Th0rgal merged 1 commit into
masterfrom
fix/agy-background-handoff-active

Conversation

@Th0rgal

@Th0rgal Th0rgal commented Oct 28, 2026

Copy link
Copy Markdown
Owner

A turn that ends while agy's own background task still runs was parked as
interrupted/usage_limit_wait, so the mission looked stopped for the ~80 s
before its automatic replay (mission 2e3bf791). Give the handoff its own
terminal reason (background_task_handoff) and keep the mission Active; the
replayer, recovery payload and Stop handling recognise both reasons.

A turn that ends while agy's own background task still runs was parked as
interrupted/usage_limit_wait, so the mission looked stopped for the ~80 s
before its automatic replay (mission 2e3bf791). Give the handoff its own
terminal reason (background_task_handoff) and keep the mission Active; the
replayer, recovery payload and Stop handling recognise both reasons.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T08:07:48.594427Z 24fec26 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 24fec26e8a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +47 to +48
if reason == BACKGROUND_HANDOFF_REASON {
MissionStatus::Active

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Allow active background handoffs through the replay dispatch guard

After an Antigravity background-task handoff, keeping the mission Active prevents its automatic continuation: replay_remote_mission_after_usage_limit calls continue_on_node, whose continue_inner rejects placement.live || mission.status == MissionStatus::Active with REMOTE_JOB_STILL_RUNNING (src/api/control/remote_grok.rs:3180–3197), even when the previous node job is terminal and its lease has been finished. The replayer therefore retries every five minutes and eventually marks the mission failed instead of continuing it. Update that dispatch guard to distinguish this replayable handoff from an actually running job, and exercise the real continuation path in the regression test.

Useful? React with 👍 / 👎.

@Th0rgal
Th0rgal merged commit 02b10c9 into master Oct 28, 2026
14 checks passed
@Th0rgal
Th0rgal deleted the fix/agy-background-handoff-active branch October 28, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant