Skip to content

Name backend Core and unify Inbox summary selection across clients - #1389

Merged
Th0rgal merged 6 commits into
masterfrom
codex/core-experience
Oct 28, 2026
Merged

Th0rgal merged 6 commits into
masterfrom
codex/core-experience

Conversation

@Th0rgal

@Th0rgal Th0rgal commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

Core is the backend product name throughout active documentation and client settings, with a short former-name note. Existing executable names, service units, environment variables, storage paths and protocol identifiers remain compatible.

Inbox AI summaries now use a single Off/model picker on desktop, iOS and Android. Turning summaries off preserves the saved model; selecting a model enables them. Custom model IDs apply only on confirmation, and unavailable catalogs retain the remembered choice. Shared fixtures cover the same transitions on all three platforms.

The mobile release versions advance together to 1.20.0 (iOS 2026102803, Android 43). iOS project regenerated with XcodeGen 2.46.0.

Validation: full desktop unit suite passed (1614 tests plus a targeted persistence regression); relevant browser tests passed (9 passed, one production-only skip), including light/dark keyboard selection; desktop production build, Swift syntax parsing, kernel binding check and changed TypeScript syntax checks passed. Android: 192 unit tests and debug APK passed; the additional shared math-routing fixture passed. iOS: all 7 targeted methods passed after correcting stale endpoint/order/subscription assertions and restoring a real inline-math routing regression; the preceding full run passed the remaining unit tests. The math detector now matches Android and is covered by shared fixtures. The required overlay behavior tests pass; four unrelated Lightbox visual references remain stale against the pre-existing download/zoom toolbar and were not rewritten.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T11:47:46.979787Z 6c16c88 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Th0rgal

Th0rgal commented Oct 28, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a23fa8ce65

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread orb/src/inboxSettings.tsx Outdated
@Th0rgal

Th0rgal commented Oct 28, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 9d92b9b0e6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Th0rgal
Th0rgal merged commit a22c2da into master Oct 28, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant