Repository navigation
TD-5229: a failed update check says why - #113
Merged
Merged
Conversation
Check for updates showed only "release fetch failed: error sending request for url (...)", reqwest's top line. The reason (no route, refused, DNS, certificate) is in the error's source chain, which this path dropped, so a dropped network looked the same as a blocked or intercepted one. The check now says in words what failed (timed out, could not connect, or the request failed), asks to check the network, and keeps the cause chain as details. Reading the release list, the checksum file and download chunks keep the chain too. On the Mac where it was reported, the same request with the updater's own client settings returned 200 later the same day (real certificate, no proxy), so the failure was the network at that moment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HUthoCdmzg2hy89ssk2cSF
captcrock
force-pushed
the
td/5229-update-error
branch
from
November 3, 2026 16:28
49ac289 to
fc1a28b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Settings → About → Check for updates showed only
release fetch failed: error sending request for url (...), which is reqwest's top line. The reason is in the error's source chain, which this path dropped.The check now says in words what failed (timed out, could not connect, or the request failed), asks to check the network and try again, and keeps the full cause chain as details. Reading the release list, the checksum file and download chunks keep the chain too.
Why it failed
On the Mac where it was reported, the same request with the updater's exact client settings (reqwest 0.12.28, rustls, same timeouts and user agent) returned 200 later the same day, with GitHub's real certificate and no proxy configured. So it was the network at that moment, not a block or an intercepted certificate. With this change the next failure will say which.
Tests
updater::fetch::tests::an_unreachable_check_says_why: a real refused connection on loopback (no outside network); the message names the failure and carries the OS reason. Fails against the old message.cargo test --lib136 passed;cargo clippy --all-targets -- -D warningsclean.🤖 Generated with Claude Code
https://claude.ai/code/session_01HUthoCdmzg2hy89ssk2cSF