Repository navigation
TD-5231: agent-desktop's cursor works from the packaged app - #117
Merged
Merged
Conversation
Two bugs from the TD-5227 live check against the packaged build: - Two sessions whose first element command ran at the same moment each started an agent-desktop session; one session's refs then resolved in the other's namespace (SNAPSHOT_NOT_FOUND). Start, turn-off and end of the cursor session now run under one asyncio lock; commands themselves still run in parallel. - The agent-desktop copy bundled inside TST Desk reports "TST Desk" as the owner of its cursor windows, so captures that left out the owner name "agent-desktop" kept them. The host and the Python fallback now also match the owning process's executable (proc_pidpath), which keeps TST Desk's own windows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HUthoCdmzg2hy89ssk2cSF
captcrock
force-pushed
the
td/5231-ax-cursor-packaged
branch
from
November 3, 2026 17:26
f4730f7 to
4703d7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two bugs from the TD-5227 live check against the packaged build:
SNAPSHOT_NOT_FOUND).AxCursornow serializes start, turn-off and end under one asyncio lock; the commands themselves still run in parallel.agent-desktopmissed them. The host (cu_capture.rs) and the Python fallback now also match the owning process's executable viaproc_pidpath, which keeps TST Desk's own windows.Tests
test_two_first_commands_at_once_start_one_session(fails without the lock); the cursor tests pass (20).process_namereads this process. Suite on macOS: 661 passed, plus the 3 failures that main already has (DarwinBackend.hit_test). mypy: the same 4 errors as main.executable_namereads this process and refuses nonsense;cargo test --lib150 passed,cargo clippy --all-targets -- -D warningsclean.Live (packaged binaries, macOS)
🤖 Generated with Claude Code
https://claude.ai/code/session_01HUthoCdmzg2hy89ssk2cSF