Repository navigation
TD-5232: an element action in full control moves the ring to its display - #118
Merged
Merged
Conversation
A pointer action and a screenshot aimed the ring at their display, but a ui_action did not, so in full control a client acting on an element on another display left the ring on the primary display. After a ui_action whose reply carries the element's frame, the ring is now aimed at the display under the element's centre, as for a click. The backlog also records the live checks run against a packaged build of b383be3 for TD-5226, TD-5227 and TD-5228 (signed build), and marks the stories that are complete. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HUthoCdmzg2hy89ssk2cSF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A pointer action and a screenshot aimed the ring at their display, but a
ui_actiondid not. So in full control, a client acting on an element on another display left the ring on the primary display. After aui_actionwhose reply carries the element's frame (TD-5227), the ring is now aimed at the display under the element's centre, as for a click._aim_overlaybecomesaim_overlaysoui.pycan use it.The backlog also records the live checks run against a packaged build of
b383be36:Stories that are complete are marked Done.
Tests
test_frame_center_with_a_clicknow checks the target display with two displays; it fails without the change.DarwinBackend.hit_test). mypy: the same 4 errors as main.ui_actionon Calculator on the left display lit that display's ring.🤖 Generated with Claude Code
https://claude.ai/code/session_01HUthoCdmzg2hy89ssk2cSF