Repository navigation
fix(install-settings): say when a guarded hook is being skipped - #336
Open
chuycepeda wants to merge 1 commit into
Open
chuycepeda wants to merge 1 commit into
chuycepeda wants to merge 1 commit into
Conversation
Every AIOS hook is guarded so a missing file is skipped instead of blocking every prompt, and nothing said when that happened. The installer now prints `! missing <event> <path>` for each guarded hook or status line whose file is gone, and `! link` when ~/aios does not lead to the framework while some hook goes through it (a note when it leads to another copy). /aios:update relays the missing lines on every run (Step 6.85). Paths and event keys with control characters never print, so settings content cannot forge an installer line. Closes #334 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ri8aqK7pwGNSj7zCjcvetU
2 of 3 tasks
Member
Author
|
Held for v0.8.20 (end of this week), merged together with #330: nothing is broken in 0.8.19 because every old hook path still forwards, so the risk this guards arrives only when #330 removes those paths. Before merge: move the CHANGELOG line into the v0.8.20 entry and credit the author of #335 (closed as a duplicate of this) as co-author. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #334. Thanks to its reporter for a precise repro with a control.
What
Every AIOS hook is written as
[ ! -f FILE ] || CMD, so a missing file is skipped instead of blocking every prompt. The price was silence: nothing said a hook stopped running.install-settings.pynow prints! missing <event> <path>for each guarded hook or status line whose file is gone, in the dry run and--apply.$HOMEand${HOME}expand unquoted and inside double quotes, not inside single quotes.~expands only when unquoted. A quoted~is reported with why the shell skips it.~ move) are not reported.! linkwhen~/aiosdoes not lead to the framework while some hook goes through it. The line covers a missing link and a dangling one, with the fix: move it aside if needed, thenln -sn. When~/aiosleads to another copy of AIOS, a note says so instead./aios:updateStep 6.85 runs the dry run on every update and relays the! missinglines. A hook goes missing on the runs that rename or remove one, not only when the installer changes. The step treats the path as data, checks the file is really gone before offering to remove the hook, and changes nothing without a yes.Review and tests
tests/install-settings.test.sh: 69/69. The new cases fail on the old code: the missing hook, the missing status line, the link line, the other-copy note, Step 6.85, and the absolute-root case.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ri8aqK7pwGNSj7zCjcvetU