Repository navigation
Re-sync KITT 5033d1e: /status no longer re-rings an unchanged ask - #75
Merged
Merged
Conversation
Brings KITT #280: the needs-you alert keys a banner on its own block, ending at its closing rule, so /status reproducing an open ask inside a longer briefing rings nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UMMrrs6msaFav9KMGMkyyd
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
This re-syncs DojoOS with KITT PR #280 — Needs-you alert: key a banner on its own block, so /status does not re-ring an unchanged ask. It closes the gap Codex found on DojoOS PR #74 — Re-sync KITT db6e309: one ask rings once, not on every later hand-back.
The needs-you alert now matches a banner only on its own text, ending at the banner's closing rule. Before this, when
/statusreproduced an open ask inside a longer briefing, the alert treated it as a new ask and rang again. Now it rings nothing. Only the alert script and its test change.Oracle source: Tier A, the bugfix oracle in KITT PR #280 — Needs-you alert: key a banner on its own block, so /status does not re-ring an unchanged ask.
Decisions taken on my recommendation
None beyond KITT PR #280 — Needs-you alert: key a banner on its own block, so /status does not re-ring an unchanged ask.
Latitude this grants me: none.
Verification
node --test scripts/__tests__/needs-you-alert.test.mjs: 25 pass, 0 fail.Post-merge verification: the close-out Repl sync.
Generated by Claude Code