Skip to content

Bug: the meme page's "Make this fact about me" opens a separate builder instead of the standard one - #852

Merged
TheAnswerManIsHere merged 1 commit into
mainfrom
claude/bugfix-make-it-your-own
Nov 3, 2026
Merged

TheAnswerManIsHere merged 1 commit into
mainfrom
claude/bugfix-make-it-your-own

Conversation

@TheAnswerManIsHere

Copy link
Copy Markdown
Owner

Workstream: #851

What & why

On someone else's meme, a signed-in visitor's "Make this fact about me" opened the meme page's own builder overlay, headed "Make this fact about you". That was the older universal builder, not the wizard every other path uses. It now goes to the standard builder on the fact's own route, /facts/:id/meme, the same place "Make a meme of this" on a fact's page goes, with the fact already chosen. The overlay, the old builder and the four parts only it used are deleted.

Approved-plan oracle

Oracle source: bugfix, Tier A

Tier rationale: a client-side change of destination plus a deletion of code with no remaining caller. It touches no auth, payments, migration, sensitive subsystem or server path. The builder it now opens is the existing wizard, unchanged, already reached by this route from the fact page.
Reported symptom: "The whole "Make this fact about you" builder shouldn't exist! I'm not sure where it came from or how it got built, but in my eyes, what should happen when you click the link is it should simply take you to the existing builder as if you had clicked on the "Make a meme" button just like you normally would. The only difference being that you don't have to select the meme, because it's implicitly selected." (David, 2026-11-03, during the UAT for Issue #719)
Intended correct behavior: "Make this fact about me" on a meme page, for a registered or Legendary visitor looking at someone else's meme, opens the standard meme builder (MemeBuilderWizard) on /facts/<the meme's fact>/meme.
Must not change:

  • the signed-out visitor's sign-up card;
  • the creator's own download and share actions;
  • the wizard itself and its identity gate on that route;
  • the "View full fact" link.
    Root cause: MemePage.tsx's openMakeAboutMe mounted pages/memePage/BuilderOverlay.tsx, which wrapped the legacy components/meme-builder/MemeBuilder.tsx. That was a second builder, left live after launch Phase 4 removed the other legacy studio.
    Blast radius:
  • BuilderOverlay had one importer, MemePage.tsx. MemeBuilder.tsx had two: BuilderOverlay and the unused __demo__/MatrixHarness.tsx, which is deleted too.
  • With them gone, EntryFlowHeader, NameAndPronounFields, ActionBar and TierLockedState had no importer left and no test, so they are deleted.
  • Shared modules the wizard still uses are kept: LivePreview, MyImagePicker, CaptionFontPicker, useBuilderState, VisibilityToggle, captionFont.
  • Modules now reached only by their own tests (behaviorMatrix, integration/sourceKinds, hooks/useDebouncedValue) are left alone and recorded below.
  • No e2e journey opened the overlay (grep for the header and for BuilderOverlay over e2e/ found nothing).

Decisions taken on my recommendation

  • The button waits for the fact to load, then navigates. It used to wait for the fact's template so the overlay could render it. Now it waits so a meme whose fact is gone never opens an empty builder. Undo: navigate on meme.factId alone in openMakeAboutMe.
  • Dead code left for later: behaviorMatrix.ts, integration/sourceKinds.ts and hooks/useDebouncedValue.ts. Each is now reached only by its own tests. Deleting them is a cleanup with no visible effect, so it is taken as next, not widened into this fix. Undo: n/a.

Latitude granted to me: none.

Verification

  • New src/pages/MemePage.test.tsx: a registered and a Legendary visitor click "Make this fact about me" and land on /facts/42/meme, and no "Make this fact about you" builder appears.
    • Against origin/main's page it fails: Expected: "/facts/42/meme", Received: "/m/abc", 2 failed.
    • With the fix it passes, 2 of 2.
  • pnpm run typecheck: clean.
  • Frontend suite (npx vitest run): 101 files, 1048 tests passed.
  • Docs: architecture-map.md and meme-and-video-studio.md now say there is one builder and how the meme page reaches it.

Post-merge verification (live environment)

none needed

Checklist

  • Docs stay true: the two docs that described the overlay as live are updated.
  • General fix, not one example: both visitor kinds that see the button are tested, and every module only the deleted builder used is swept.
  • In scope: one bug.

Generated by Claude Code

…with the fact chosen (#851)

The meme page opened its own builder overlay (the legacy universal
MemeBuilder) instead of the wizard every other path uses. The button now
navigates to the fact's builder route, /facts/:id/meme, and the overlay,
the old builder and the parts only it used are deleted.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UMMrrrX1dR5EdX15XJxkAZ
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T05:49:59.560768Z abd0511 PR opened
🔒 Security Review ✅ Completed 2026-11-03T05:50:37.852003Z abd0511 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@TheAnswerManIsHere
TheAnswerManIsHere merged commit bb8cce3 into main Nov 3, 2026
13 checks passed
@TheAnswerManIsHere
TheAnswerManIsHere deleted the claude/bugfix-make-it-your-own branch November 3, 2026 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants