Repository navigation
Bug: the meme page's "Make this fact about me" opens a separate builder instead of the standard one - #852
Merged
Conversation
…with the fact chosen (#851) The meme page opened its own builder overlay (the legacy universal MemeBuilder) instead of the wizard every other path uses. The button now navigates to the fact's builder route, /facts/:id/meme, and the overlay, the old builder and the parts only it used are deleted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UMMrrrX1dR5EdX15XJxkAZ
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workstream: #851
What & why
On someone else's meme, a signed-in visitor's "Make this fact about me" opened the meme page's own builder overlay, headed "Make this fact about you". That was the older universal builder, not the wizard every other path uses. It now goes to the standard builder on the fact's own route,
/facts/:id/meme, the same place "Make a meme of this" on a fact's page goes, with the fact already chosen. The overlay, the old builder and the four parts only it used are deleted.Approved-plan oracle
Oracle source: bugfix, Tier A
Tier rationale: a client-side change of destination plus a deletion of code with no remaining caller. It touches no auth, payments, migration, sensitive subsystem or server path. The builder it now opens is the existing wizard, unchanged, already reached by this route from the fact page.
Reported symptom: "The whole "Make this fact about you" builder shouldn't exist! I'm not sure where it came from or how it got built, but in my eyes, what should happen when you click the link is it should simply take you to the existing builder as if you had clicked on the "Make a meme" button just like you normally would. The only difference being that you don't have to select the meme, because it's implicitly selected." (David, 2026-11-03, during the UAT for Issue #719)
Intended correct behavior: "Make this fact about me" on a meme page, for a registered or Legendary visitor looking at someone else's meme, opens the standard meme builder (
MemeBuilderWizard) on/facts/<the meme's fact>/meme.Must not change:
Root cause:
MemePage.tsx'sopenMakeAboutMemountedpages/memePage/BuilderOverlay.tsx, which wrapped the legacycomponents/meme-builder/MemeBuilder.tsx. That was a second builder, left live after launch Phase 4 removed the other legacy studio.Blast radius:
BuilderOverlayhad one importer,MemePage.tsx.MemeBuilder.tsxhad two:BuilderOverlayand the unused__demo__/MatrixHarness.tsx, which is deleted too.EntryFlowHeader,NameAndPronounFields,ActionBarandTierLockedStatehad no importer left and no test, so they are deleted.LivePreview,MyImagePicker,CaptionFontPicker,useBuilderState,VisibilityToggle,captionFont.behaviorMatrix,integration/sourceKinds,hooks/useDebouncedValue) are left alone and recorded below.grepfor the header and forBuilderOverlayovere2e/found nothing).Decisions taken on my recommendation
meme.factIdalone inopenMakeAboutMe.behaviorMatrix.ts,integration/sourceKinds.tsandhooks/useDebouncedValue.ts. Each is now reached only by its own tests. Deleting them is a cleanup with no visible effect, so it is taken as next, not widened into this fix. Undo: n/a.Latitude granted to me: none.
Verification
src/pages/MemePage.test.tsx: a registered and a Legendary visitor click "Make this fact about me" and land on/facts/42/meme, and no "Make this fact about you" builder appears.origin/main's page it fails:Expected: "/facts/42/meme",Received: "/m/abc", 2 failed.pnpm run typecheck: clean.npx vitest run): 101 files, 1048 tests passed.architecture-map.mdandmeme-and-video-studio.mdnow say there is one builder and how the meme page reaches it.Post-merge verification (live environment)
none needed
Checklist
Generated by Claude Code