Charges shouldn't set true cooldown#1083
Open
JasperLorelai wants to merge 1 commit into
Open
Conversation
This reverts changes from d8c0381, as they have introduced a bug where once all charges are depleted, you have to wait for the full recharge duration instead of the short time until the next recharge. Combined with the fix this addresses the original issue of "-1" cooldown - "Spell#getCooldown" will now return the time of the next available recharge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue where once all
chargeswere depleted, you had to wait for the full cooldown because the true cooldown was set. Instead, the spell will only be "considered" on cooldown until the next recharge, while all charges are depleted.