Repository navigation
fix: test the compiled version lookup without a tsx subprocess - #15
Merged
Merged
Conversation
The subprocess loaded a copied .ts file through tsx, which fails with ERR_REQUIRE_CYCLE_MODULE on one of anvil's reproducibility runners and blocked the release. readPackageVersion now takes its base URL, so the test calls it directly against a temporary dist/src layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underpayment fixes (#13) couldn't publish: the version test spawned tsx on a copied .ts file, which fails with ERR_REQUIRE_CYCLE_MODULE on one of anvil's two reproducibility runners. The test now calls
readPackageVersiondirectly with a base URL in a temporarydist/srclayout. Nothing was published or deployed by the failed runs.