Repository navigation
fix(funding): treat products past their application end date as closed - #34
Merged
Merged
Conversation
evaluateProduct ignored the application period, so a reviewed product recorded as OPEN stayed a current candidate after its end date until the next review date, against AGENTS.md section 3 item 8. A product whose end date is before the as-of date is now CLOSED whatever its observed status; the end date itself still counts as open, and a missing end date keeps the observed status. The candidate, funding-match and loan-assumption API tests judge with the real KST date, and their fixtures ended on 2026-12-31, so they would fail from 2027. Their end dates now use FAR_FUTURE like nextReviewAt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015LCE4DgT5qdHP8y8V5qtbL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련: ADR 0006(#33) 6절의 "신청 종료" 강등 규칙. 이 수정은 지금 규칙(AGENTS.md §3의 8번)을 지키게 하는 것이라 ADR 병합과 상관없이 병합할 수 있다. 별도 Issue는 없다.
변경 내용
eligibility.ts): 지금까지evaluateProduct는 신청기간을 보지 않았다. 그래서 검수를 마치고 OPEN으로 기록한 상품이 신청 종료일 뒤에도 재검수일까지 현재 후보로 남았다. 이는 종료된 상품을 현재 신청 가능으로 표시하지 않는다는 AGENTS.md §3의 8번과 어긋난다.CLOSED로 판정하고 종료일을 사유에 적는다.docs/domains/funding.md판정 절에 이 규칙을 적었다.CLOSED다.todayInKst())로 판정한다. 그런데 fixture 종료일이2026-12-31이라, 이 수정 뒤에는 2027년부터 7개 테스트가 실패한다. 검수일(nextReviewAt)처럼FAR_FUTURE로 바꿨다.검증
CURRENT_CANDIDATE). 수정 후 통과한다.npm --prefix app run verify:fast통과: 카탈로그 검증, Prettier, ESLint, TypeScript, 테스트, build.data/raw/가 없을 때의 원본 대조 테스트 6개다.verify:db: 261 passed, 6 skipped(data/raw/가 없을 때의 원본 대조 테스트). PR #35가 들어간 최신 main을 합친 뒤에도 같은 결과였고,verify:fast도 다시 통과했다.verify명령 하나로 실행하지 않고 같은 단계를 나눠 실행했다.위험·후속
CLOSED를 재사용한다.CLOSED가 된다. 종료가 확정된 사실이기 때문이다.OBSERVED_OPEN_BEFORE_PERIOD_START)이 이미 막는다.🤖 Generated with Claude Code
https://claude.ai/code/session_015LCE4DgT5qdHP8y8V5qtbL
Generated by Claude Code