Repository navigation
deps: bump Python group (except bgutil) and fix pytest 9.2 / ruff 0.17 fallout - #6
Merged
Merged
Conversation
The plugin hard-fails on a major-version mismatch with the vendored server script, so a major bump has to move both together by hand. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wakepy 1.0 moved its dynamically registered keep-awake methods from `_implementations` to `methods`. The stale hidden import only warned at build time, so the frozen app would silently stop keeping the PC awake. Adds a guard test that every spec hidden import resolves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Replaces #5 (Dependabot's grouped Python bump) and keeps 10 of its 11 updates.
bgutil-ytdlp-pot-providerstays at 1.3.1: the plugin hard-fails on a major-version mismatch with the server script vendored invendor/bgutil-pot-provider/, so the 2.0.2 bump would have broken PO-token minting. A major bump has to move both by hand.dependabot.ymlnow ignores major versions of that package until then.Fixes for what the bumps broke:
LogCaptureHandlerto loggers withpropagate=False.get_ytdlp_debug_logger()usedif debug_logger.handlers:as its "already set up" check, so it treated pytest's handler as its own and never opened the debug log. It now finds its handler by name (set_name/get_name).select = ["ALL"]now enforces:LOG004caught a real bug. After a failed download,QYTQueue.downloadcalledQLogger.exception()with no exception active, so the log showed aNoneType: Nonetraceback. That call is now.error().QLogger.exceptionhad no other caller (yt-dlp never calls it), so it's removed.log_exceptionnow passesexc_info=excexplicitly, so the traceback comes from the exception it was given.CPY001(per-file copyright header) andPLR0917(positional sibling of the already-ignoredPLR0913) are ignored.Regression tests:
test_foreign_handler_does_not_block_file_handlerandtest_log_exception_outside_except_block_records_passed_traceback.Checklist
uv run pytest -qpasses (1973 passed, 14 skipped)uv run ruff checkanduv run ruff format --checkare cleanuv run basedpyrightreports no new errors.env.exampleupdated if a setting or user-visible behaviour changed (n/a)🤖 Generated with Claude Code