Repository navigation
Fix auth status treating "Not logged in" as logged in - #14
Merged
TheOnlyFusionCube merged 1 commit intoOct 24, 2026
Merged
TheOnlyFusionCube merged 1 commit into
TheOnlyFusionCube merged 1 commit into
Conversation
`devin auth status` exits 0 when logged out and prints "Not logged in.", a credentials path, and a "Run `devin auth login`" hint. The old /logged in/i check matched that hint text, so setup reported authenticated:true for a logged-out user. Now a session counts as logged in only when a line starts with "logged in" and the output does not contain "not logged in". Adds a loggedOutExitZero fake-devin option and a setup regression test.
TheOnlyFusionCube
approved these changes
Oct 24, 2026
TheOnlyFusionCube
left a comment
Owner
There was a problem hiding this comment.
Approved. The new positive, line-anchored logged in match plus explicit not logged in exclusion fixes the misleading exit-0 output without changing binary resolution from #13 or other auth failure paths. The fake CLI reproduces the real logged-out banner and /devin:setup --json checks both authenticated: false and ready: false. The Test matrix (Node 18/20/22, npm test and npm run doctor) passed. HOL Scanner still fails, but this PR reports the same one high as current main (98/100); do not lower security thresholds to address that separate baseline issue. No blocker found in this patch.
TheOnlyFusionCube
merged commit Oct 24, 2026
c9fff3b
into
TheOnlyFusionCube:main
3 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-file of the former #1, as requested in #4, rebased onto current main.
What was wrong:
devin auth statusexits 0 when you're logged out. It prints "Not logged in.", a credentials path, and a hint to rundevin auth login.getDevinAuthStatustested the output with/logged in/i, which matches that text too. So/devin:setupreportedauthenticated: trueandready: truefor a logged-out user.How it was observed: on Devin CLI 3000.10.x a logged-out
devin auth statusprints exactly that, with exit 0. A logged-in session starts with "Logged in (via Devin).", followed by indented sections that include "Email:" and "Tier:".What changed
getDevinAuthStatusnow counts a session as logged in only when a line starts with "logged in" (case-insensitive) and the output doesn't contain "not logged in".loggedOutExitZerooption that reproduces the logged-out, exit 0 output.authenticated: falseandready: falsefor that case.How tested
node --test: 68/68, which is main's 67 plus the new test.devin.mjschange.