Repository navigation
Conversation
Contributor
|
🚀 Deployed on https://deploy-pr-347--thephpfoundation.netlify.app |
TimWolla
commented
Oct 29, 2026
TimWolla
commented
Nov 2, 2026
TimWolla
commented
Nov 2, 2026
TimWolla
commented
Nov 2, 2026
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
TimWolla
commented
Nov 2, 2026
iluuu1994
reviewed
Nov 2, 2026
Comment on lines
+120
to
+122
| long run, because they give the ecosystem something new to rely on that | ||
| replaces custom implementations, rather than just a different way to write what | ||
| already exists. |
Member
There was a problem hiding this comment.
I found this wording slightly odd. Maybe:
Suggested change
| long run, because they give the ecosystem something new to rely on that | |
| replaces custom implementations, rather than just a different way to write what | |
| already exists. | |
| long run, because they give the ecosystem a reliable design that will be | |
| consistent across projects, rather than just a different way to write what | |
| already exists. |
Contributor
Author
There was a problem hiding this comment.
That suggestion does not quite work, because the “custom implementations” is important for the “rather than just different way”.
TimWolla
commented
Nov 2, 2026
TimWolla
commented
Nov 2, 2026
Co-authored-by: Ilija Tovilo <ilija.tovilo@me.com> Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.