Repository navigation
run the AudioEngine unit-test job only for same-repo and trusted runs - #236
Merged
Merged
Conversation
Fork pull requests skip the job that downloads Findaway's licensed AudioEngine.xcframework, and a fork-notice job records the skip. The Python checks in checks.yml still run for forks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
unit testsjob intests.yml, which downloads Findaway's AudioEngine.xcframework, now runs only forworkflow_dispatch, pushes, and pull requests whose head branch is in this repository. On a fork pull request it is skipped, and a smallunit tests skipped (fork)job posts a notice so the skip is visible rather than looking like a pass.checks.ymlstill runs its Python checks for forks.Why
AudioEngine is licensed. This matches Android's handling of Findaway, which is fetched only in trusted builds; PR builds from forks go without it.
How verified
scripts/tests/test_tests_workflow.pyparsestests.ymland asserts that every job fetching fromcdn.audioengine.iocarries the trusted-runif:, and that the fork notice job exists. With the guard line deleted, the guard test fails (1 failed, 2 passed); restored,pytest scripts/tests/passes 30/30.checks.ymlnow installspyyamlalongsidepytestfor that test.actionlintreports no findings on both workflows.unit testsruns here.