Conversation
Previously only admins and network coordinators could, although hosts set it when creating the group. Area stays admin/coordinator only. The postcode is only written when the request sends it, so partial updates don't blank it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- updateGroupv2 updates only the fields present in the request (location
brings its geocoded lat/lng/country with it). A partial update previously
blanked everything else: e.g. sending just phone wiped the name, location,
coordinates, description, website, timezone, email and network_data.
- A future-event timezone change only happens when timezone is sent;
omitting it no longer counts as a change to null.
- The Archive group action sends only {id, archived_at}. It sent the whole
store group back, which saved network_data as "[object Object]".
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
edwh
changed the title
3 of 4 tasks
… the date" This reverts commit de5e718.
edwh
changed the title
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The other changes that were in this PR (saving a group changing only the fields sent, the Archive action, the timezone check) are now in #930.
Code Quality Review
Test Plan