Skip to content

Show all your groups on the Your groups tab, not just the first page - #929

Open
edwh wants to merge 1 commit into
developfrom
fix-928-your-groups
Open

edwh wants to merge 1 commit into
developfrom
fix-928-your-groups

Conversation

@edwh

@edwh edwh commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #928.

Summary

  • Before: on the Your groups tab, someone who follows a lot of groups saw only the first page (around 20–25, A to H for Florine). Scrolling down loaded no more.
  • Why: the tab fetches each of your groups separately. The list loads more rows as you scroll, but it checked before most of the groups had arrived. It found nothing more to show, stopped, and never checked again.
  • After: the list starts checking again whenever more groups arrive, or when the groups in view change on the map. Scrolling down now reaches all your groups.

Code Quality Review

  • One small change in GroupsTable.vue: the scroller gets an identifier that changes when more groups arrive. This is the documented way to restart vue-infinite-loading.
  • The map tab uses the same table and gets the same fix. Before, zooming out after the list had already ended could also leave groups unreachable.

Test Plan

  • New jest test: groups that arrive after the scroller has stopped can still be scrolled to. It fails without the fix and passes with it.
  • Full jest suite passes (166 tests).
  • Checked on the preview with an account in 60 groups: scrolling down shows all 60.

The Your groups tab fetches each group separately. If the list's
infinite scroller checked before most had arrived, it decided there
were no more rows and never asked again, so only the first page ever
showed. Restart the scroller whenever more groups arrive, or the
groups in view change.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@edwh edwh added the preview Deploy a Fly.io preview for this PR label Oct 1, 2026
@edwh
edwh deployed to preview October 1, 2026 15:59 — with GitHub Actions Active
@sonarqubecloud

sonarqubecloud Bot commented Oct 1, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Preview: https://restarters-pr-929.fly.dev

✅ Ready - restore and migrations succeeded.

  • Password-protected test environment (usual dev gate password); commit cbbd38051b3657af0a0ef6e9a3bba3bc4857488a merged with develop.
  • If you see a "warming up" page, give it a few minutes - it refreshes itself.
  • The preview database is refreshed on every deploy and may reset at any time; anything you create here is disposable.
  • Emails go to shared Mailpit, never to real recipients. Image uploads are disabled.
  • The app suspends when idle; the first request after a pause can take a moment.

This branch was successfully deployed

1 active deployment
preview — cbbd3805 Deployed Oct 1, 2026 by edwh via Deploy preview #518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview Deploy a Fly.io preview for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not all user's groups are showing under 'Your groups'

1 participant