Skip to content

Network page: show more groups with a button, so the tags stay reachable - #931

Open
edwh wants to merge 1 commit into
developfrom
network-groups-show-more
Open

edwh wants to merge 1 commit into
developfrom
network-groups-show-more

Conversation

@edwh

@edwh edwh commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

For #918.

Summary

  • Before: on a network page, the list of groups under the map loaded more groups as you scrolled down. On big networks (Hauts-de-France, Repair Together) the group tags section below kept moving out of reach just as you got to it.
  • After: the network page shows a page of groups (25), then a Show more groups (25 of 180) button. The list only grows when you press it, so the tags section stays reachable.
  • Why not a fixed-height list that scrolls inside the page: that works on desktop, but on a phone you end up with two scrollable areas on top of each other, and the inner one can be taller than the screen. A button keeps a single scroll on every screen size.
  • The groups page keeps scrolling as before. Nothing below its list needs reaching.

Code Quality Review

  • GroupsTable gets a showMoreButton option. The network page turns it on (passed through GroupMapAndList); everywhere else is unchanged.

Test Plan

  • Jest: with the option on, there's no infinite scroll, the button adds a page, and it disappears once every group is shown. The network page turns it on.
  • Full jest suite passes.
  • Checked on the preview with Hauts-de-France (245 groups), on a computer and a phone: scrolling no longer grows the list; the button adds 25 groups each time.

The list under the network map loaded more groups as you scrolled, so
on a big network the tags section below kept moving out of reach. On
the network page it now shows a page of groups with a 'Show more
groups' button. One scroll, so it works on mobile too, unlike a
fixed-height list. The groups page keeps its infinite scroll, since
nothing below the list needs reaching.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@edwh edwh added the preview Deploy a Fly.io preview for this PR label Oct 1, 2026
@edwh
edwh deployed to preview October 1, 2026 16:46 — with GitHub Actions Active
@sonarqubecloud

sonarqubecloud Bot commented Oct 1, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Preview: https://restarters-pr-931.fly.dev

✅ Ready - restore and migrations succeeded.

  • Password-protected test environment (usual dev gate password); commit acf9e8cf26932375c1c421976c707c9672466c92 merged with develop.
  • If you see a "warming up" page, give it a few minutes - it refreshes itself.
  • The preview database is refreshed on every deploy and may reset at any time; anything you create here is disposable.
  • Emails go to shared Mailpit, never to real recipients. Image uploads are disabled.
  • The app suspends when idle; the first request after a pause can take a moment.

This branch was successfully deployed

1 active deployment
preview — acf9e8cf Deployed Oct 1, 2026 by edwh via Deploy preview #522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview Deploy a Fly.io preview for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant