Skip to content

fix(skill): conflict skill popup style fix#1840

Merged
zhangmo8 merged 1 commit into
devfrom
fix-style
Jun 30, 2026
Merged

fix(skill): conflict skill popup style fix#1840
zhangmo8 merged 1 commit into
devfrom
fix-style

Conversation

@zhangmo8

@zhangmo8 zhangmo8 commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

before:
042dad88-a0a6-437e-b761-7845b9fb2520

after:
7470f3e3-19db-4598-8df4-88c23288c113

Summary by CodeRabbit

  • Style
    • Improved the layout of skill adoption preview details for better readability.
    • Long path values now wrap cleanly across multiple lines instead of being cut off on one line.
    • Preserved hover tooltips for the displayed paths.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: aff33c4a-07dc-4970-b77a-22c7d7868768

📥 Commits

Reviewing files that changed from the base of the PR and between ea67a5a and 0c9debf.

📒 Files selected for processing (1)
  • src/renderer/settings/components/skills/AdoptSkillDialog.vue

📝 Walkthrough

Walkthrough

In AdoptSkillDialog.vue, the preview block showing current location, post-adoption target/agent paths, and backup root is reformatted: wrappers gain min-w-0, and path text switches from single-line truncate to multi-line break-all with text-xs leading-5.

Changes

Path Preview Layout

Layer / File(s) Summary
Preview path text wrapping
src/renderer/settings/components/skills/AdoptSkillDialog.vue
Adds min-w-0 to section wrappers and replaces truncate with break-all leading-5 on monospaced path elements for all four preview.* bindings.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A path too long would hide from sight,
Now breaking where it must to fit just right,
No truncate cloak to shrink the trail,
Each folder name told without fail.
🐇 The rabbit hops and reads it all!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the PR’s main change: a style/layout fix for the conflict skill popup dialog.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-style

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zhangmo8 zhangmo8 merged commit 050d014 into dev Jun 30, 2026
3 checks passed
@zhangmo8 zhangmo8 deleted the fix-style branch June 30, 2026 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant