Skip to content

ci: test only the Node versions package.json supports #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThinkOffApp merged 1 commit into from
Oct 4, 2026
Merged

ci: test only the Node versions package.json supports #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,13 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x, 20.x, 22.x]
# Matches the engines floor in package.json (">=20"). 18.x was tested
# here while unsupported, and had been failing since at least 22 Sep on
# packages/user-intent-kit/test/state-publisher.test.js: mock.timers
# .enable() took a bare array in Node 18 and an options object from 20,
# so {apis:[...]} is ERR_INVALID_ARG_TYPE there. A permanently red check
# on an unsupported runtime trains everyone to ignore CI.
node-version: [20.x, 22.x]

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve Node 18 coverage for the nested package

Removing 18.x from this matrix also removes the only Node 18 run of packages/user-intent-kit/test/*.test.js, although packages/user-intent-kit/package.json still declares node >=18 and the root npm test explicitly includes that suite. Consequently, changes that break this separately documented package for supported Node 18 users can now merge unnoticed; either retain a Node 18 job for the nested package and make its timer test version-compatible, or raise that package's engine floor as well.

Useful? React with 馃憤聽/ 馃憥.

steps:
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
Expand Down
Loading