Repository navigation
feat(application): read bounded source-local SDK clones - #1018
Merged
Merged
Conversation
pengfei-threemoonslab
force-pushed
the
codex/874-instance-tool-flow
branch
from
October 10, 2026 20:01
bef21d5 to
73c42ad
Compare
pengfei-threemoonslab
force-pushed
the
codex/911-agent-clones
branch
from
October 10, 2026 20:04
a63f0c8 to
8ed96b3
Compare
1 of 2 tasks
pengfei-threemoonslab
marked this pull request as ready for review
October 10, 2026 20:35
pengfei-threemoonslab
force-pushed
the
codex/874-instance-tool-flow
branch
from
October 10, 2026 22:39
73c42ad to
46e404e
Compare
pengfei-threemoonslab
changed the base branch from
codex/874-instance-tool-flow
to
main
October 10, 2026 22:53
pengfei-threemoonslab
force-pushed
the
codex/911-agent-clones
branch
from
October 10, 2026 22:54
3618a30 to
5daa9a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Application comparison can now read an OpenAI Agents SDK clone from a unique source-local SDK agent, retaining inherited tool, handoff and MCP lists and explicit overrides. Narrowing the clone produces rows for the clone while preserving the source agent.
Refs #911. Stacked on #1017 (
codex/874-instance-tool-flow). This is a bounded source-local increment: imported/custom-instance/template receivers and full GRAAL acceptance remain open. Corpus scores, ledgers, goldens, baselines and released-build evaluation are deferred by the owner.Boundaries
agent_settingscarries recognized source literals, not runtime authority. Tools remain bound undertool_choice="none". Conflicting or unread settings carry row-specific uncertainty.Authorship
Validation
92 new clone tests passed, including real Git/CLI before/after comparisons, constructor and alias refusals, handoffs/MCP, identity movement, unread replacements, settings conflicts and shallow-copy mutations.
Independent review passed 310 related tests and the final 214-test selection, plus explicit no-alias sharing and separate-new-list probes.
Final stable constructor compatibility selection: 913 passed. After the final binding-scope absence correction, clone/source-identity/unobserved compatibility: 214 passed independently and locally.
An earlier related selection had no assertion failures but six frozen-engine fixture errors because the implementation moved during that run. The affected constructor modules were rerun against unchanged source and all 913 cases passed.
Ruff and diff whitespace checks passed.
Original committed-source verifier/control at
a63f0c817ef0:complete, release decisionpassed.Sequential restack at
8ed96b350e60: candidate-object refusals and candidate uncertainty annotations were retained alongside clone filtering and inherited handoffs. 94 candidate/clone tests passed before the unchanged scope-fix replay; extra independent combination review passed 383 tests and found no actionable P1/P2; candidate uncertainty, inherited conditions and refusal routes were preserved. Committed control iscomplete/passed; the first stacked CI exposed a stale clone-is-unread assertion; its independently reviewed correction is recorded below.CI compatibility correction at
3618a3077f31: the existing imported-tool fixture now requires all three supported clone/source changes, their exact source and empty uncertainty/gaps. Clone-method replacement and escaped-handle cases still requirepartial/not_establishedwith side-specific refusal evidence.Complete imported-tool/clone compatibility selection: 289 passed; independent test-only follow-up: all 4 original parameter cases passed, including both refusal subcases. No production source was changed. Committed control is
complete/passed; exact-head GitHub CI passed all 14 applicable checks, including six suite shards and aggregate coverage; the release-tag-only check was skipped.Six-increment combination at
a4ea56e5987bf: 1,546 passed, 1 skipped. Final product source is identical after the test-only correction; independent combination review passed 383 tests with no actionable P1/P2.Independent review and fixes
CI follow-up: the reviewer independently reproduced the obsolete
partialexpectation, verified the supported source-local clone's three changes and refusal variants, then reviewed the exact test-only correction. No actionable P1/P2 remained. CI coverage correctly rejected the earlier incomplete suite; no gate, expectation for a refusal, or test selection was weakened.The SDK clone contract is a shallow copy. No code was imported or executed to discover agent behavior.
Ordered merge preparation
This increment was replayed onto main
337fb5cd44eb, after #1017. New head5daa9a061904has exactly the same file content as reviewed head3618a3077f31(full-tree diff equality). Fresh committed control iscomplete/passed; exact-head CI for the replay passed all 14 applicable checks; release-tag-only check skipped. The preceding main commit passed all 13 CI jobs before this merge. Baseline implementation remains deferred.Post-merge main verification
Squash-merged as
662236c775b29b4cec1d424e87818743a9fa0ee9. The main tree exactly matches the reviewed PR head. Post-merge targeted tests passed: 289 tests. Fresh committed verification on that main commit returnedcomplete/passed. Main CI run completed successfully with all 13 jobs passed. Baseline, corpus, ledger, Q2 and released-build evaluation remain deferred.