Shore Ocean PR (Unfinished) - #41
ThreeEelsinaJellyfishCoat wants to merge 335 commits into
Conversation
|
Just saw what happened at Glowkate’s lol |
| shore: [ | ||
| { | ||
| name: "shore-default", | ||
| message: "The surface of the water is painfully close, yet it stretches vast.<br>Looking into the distance, that seems the least of your problems.", |
There was a problem hiding this comment.
I don't think that the <br> is needed. From what I've seen the text wraps around on its own. I may be wrong about that though.
There was a problem hiding this comment.
The, uh… the what?
I’m afraid whatever is after ‘the’ isn’t showing for me.
There was a problem hiding this comment.
Ohh! The <br>! I was partially aware that it might do that, but that’s the start of a new topic, and topic change = line change.
| }, | ||
| }, | ||
| shore: { | ||
| template: { |
There was a problem hiding this comment.
I believe the indenting on this is slightly wrong.
| desc: "What is that sandy cloud? What does it do? We should go inside it.", | ||
| researchedMessage: "It's a sandstorm. The one where the rough grains of sand come from. To say it's torture is an understatement.", | ||
| effectDesc: "If we ever escape this... this barrage, we'll never go near it again.", | ||
| cost: { |
There was a problem hiding this comment.
I'm concerned that there are too many different types of resources needed for this upgrade. Not sure how good that'll look visually.
There was a problem hiding this comment.
Yes, I also think that’s a bit too much. Perhaps I’ll remove crystals.
| desc: "We need to go back. This hurts.", | ||
| researchedMessage: "No. No, no, no, no, no. It's gone. It's covered.", | ||
| effectDesc: "Our previous location has been consumed by the sandstorm.", | ||
| cost: { |
There was a problem hiding this comment.
Same concern here. I'd limit the amount of different resources it costs to 3 or less.
| incomeMultiplier: { | ||
| crab: 2, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Indentation? May I ask what that is?
There was a problem hiding this comment.
Is it the commas and lines and stuff?
There was a problem hiding this comment.
It's the whitespace at the start of a line
There was a problem hiding this comment.
Oh, thank you!
| underwaterChemistry: {}, | ||
| thermalVents: {}, | ||
| laserRays: {}, | ||
| stabilization: {}, |
There was a problem hiding this comment.
From my memory, having upgrades that didn't previously exist be 'imported' like this causes issues.
There was a problem hiding this comment.
Hmmm… perhaps Murk Assessment could be Seabed Geology, and Our Only Choice could be Grotto? That still leaves an (almost) effectless upgrade in between, though…
Lore-wise, it was gonna be ‘hey, let’s immediately check out this sandstorm’ with the scientists, and then, uh… stuff happens, people die, blablabla, then you burst into the Expanse where you have time to do the normal upgrades. But I suppose I could sacrifice that for doing normal upgrades before. That still works lore-wise.
| present: ["mudskipper", "driftwood", "hardbark", "coral", "seagrass", "caracara"], | ||
| tip: "Not all is as it seems. Respect the brown fish that survive the beyond.", | ||
| }, | ||
| entry: "You enter a low-strung sandy sea, just over tall enough for you to fit. It's clear water on all sides, except for behind you...", |
There was a problem hiding this comment.
Improper indenting on this whole section
| "Placeholder :D", | ||
| ], | ||
| eel: [ | ||
| "Placeholder :D ...do I really have to do all these?", |
There was a problem hiding this comment.
Mayhaps you do, mayhaps you don't. Depends on if it works or not.
There was a problem hiding this comment.
My main concern is: will this code being here generate a new, working button? Or will I have to code the button to be there?
|
|
|
Thank you, everyone! This was really helpful! |
|
@glowkate , in response to your review, I have limited the Upgrade costs. Is it better now? |
i'll boot it back up again later
This branch was successfully deployed
3 participants
To-Do list can be found on the Shore Ocean thread on the Discord server.