Skip to content

ci(rust): make clippy actually run and use it as the single compile gate #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeliciousBuding merged 1 commit into from
Oct 19, 2026
Merged

ci(rust): make clippy actually run and use it as the single compile gate #2383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2202,7 +2202,18 @@ jobs:
with:
persist-credentials: false

# `components: clippy` matters: the pinned toolchain ships without it, so
# the old advisory clippy step was failing on "cargo-clippy is not
# installed" and `continue-on-error` swallowed it — clippy never ran.
- uses: dtolnay/rust-toolchain@1.96.0
with:
components: clippy

# Same cargo cache the desktop build job uses: without it every
# desktop-changed PR recompiles the whole dependency tree twice.
- uses: swatinem/rust-cache@v2
with:
workspaces: app/desktop/src-tauri -> target

- name: Install Tauri Linux system dependencies
shell: bash
Expand All @@ -2213,20 +2224,14 @@ jobs:
libxdo-dev libssl-dev libayatana-appindicator3-dev \
librsvg2-dev patchelf

# Blocking compile gate: clippy stays advisory, but a Rust build
# breakage must fail the PR here.
- name: cargo check (blocking)
working-directory: app/desktop/src-tauri
run: cargo check --all-targets

# cargo clippy advisory (owner: desktop maintainers) — 24 warnings not
# yet zero-baselined; continue-on-error so CI stays green while triaged.
# Promote to hard-blocking (cargo clippy --all-targets -- -D warnings)
# once the lint debt is repaid to zero.
- name: cargo clippy (advisory)
continue-on-error: true
# One compile pass, two properties. `cargo clippy` runs the same
# type-check as `cargo check`, so it is the blocking compile gate: it
# exits non-zero on compile errors. Lint warnings stay advisory because
# no `-D warnings` is configured (24 not yet zero-baselined); promote
# that flag once the lint debt is repaid.
- name: cargo clippy (compile gate, lint advisory)
working-directory: app/desktop/src-tauri
run: cargo clippy --all-targets 2>&1
run: cargo clippy --all-targets

# CI: cargo-audit install sped up via cargo-binstall (prebuilt binary,
# ~10s) instead of `cargo install cargo-audit --locked` which compiles
Expand Down
Loading