Repository navigation
feat(app): add the shadcn + tailwind design-system layer - #2386
Merged
Merged
Conversation
Co-authored-by: Codex <codex@delicious233.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step of the frontend rebuild: the shadcn/ui + Tailwind layer that the conversation UI will be built on. No component is migrated yet — this PR only makes the layer real, verified and mergeable, so the UI slices that follow are pure component work.
What it adds
tailwindcss+@tailwindcss/vite) plugged into both renderers (web,desktop), with the stylesheet imported once per entry.shared/src/styles/shadcn.css— the token bridge. The design system already exposed shadcn-shaped variables (--background,--foreground,--primary,--muted,--card,--border,--ring,--input,--popover,--accent,--destructive), so@theme inlinemaps Tailwind's colour namespace onto them and onto the existing--r-xs..xlradius scale. Palette and radius stay single-sourced intokens-base.css/themes.css.borderutilities draw a real border). Full preflight lands with the last old-UI removal.shared/components.jsonsopnpm dlx shadcn@latest add …keeps working against this repo's aliases (@shared/shadcn/ui,@shared/lib/utils).shared/src/lib/utils.ts(cn()= clsx + tailwind-merge) and the vendoredbuttoncomponent as the first official shadcn primitive, with a render test.Components are vendored one at a time as a surface adopts them — the other eight primitives I pulled while wiring the registry were untested dead weight and are not in this PR.
Verified
pnpm --filter agenthub-web build: passes; the emittedindex-*.csscontains--color-background/--radius-md, i.e. the theme bridge really is in the bundle.pnpm --filter @agenthub/shared typecheck,agenthub-desktop typecheck: pass.pnpm --filter @agenthub/shared lint: 0 errors (agenthub-web lint --max-warnings 0: pass).vitest run shared/src/shadcn: 2/2.Next slices
InputGroup+Attachment+Button.Message/Bubble/Tool/Reasoning, keeping the existing transcript data model.