Repository navigation
refactor(workbench): split src into domain folders - #2389
Merged
Merged
Conversation
src/ was 170 flat files: composer parts, transcript chrome, route views and inspector panels all side by side, so every import was a puzzle. - composer/ (35) - UnifiedComposer, pickers, attachments, mention, approval, dispatch queue, helpers - transcript/ (32) - ConversationHost/Sidebar, ChatViewBridge, transcript chrome, goal banner, mainchain strip - routes/ (51) - route views, hooks, helpers, planners, page models - inspector/ (37) - inspector panel, resizer, mode panel Root keeps only shell + cross-cutting files and the package.json export entry points (index.ts, designIcons.tsx, WorkbenchRoutes.tsx, hubDataMapping.ts, desktopChromeEvents.ts), so external imports are untouched. Relative imports inside src were rewritten mechanically; package exports and visual output are unchanged. Co-authored-by: Codex <codex@delicious233.com>
The export pointed at src/shadcn/ai-elements, a directory that does not exist. Vendored shadcn files live in shadcn/ui only. Co-authored-by: Codex <codex@delicious233.com>
Every composer file opened with an eight-line ASCII banner that repeated its own filename and issue number, and UnifiedComposer carried five more section dividers explaining what the next block already says. Keep comments that carry a constraint a reader cannot infer from the code: the memo rationale for keystroke re-renders, the cross-platform approval-mode mapping, and the dispatch-queue invariant that entries never resend the transcript message. Co-authored-by: Codex <codex@delicious233.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
app/workbench/src/was 170 flat files: composer parts, transcript chrome, route views and inspector panels all side by side. Split by domain, no behaviour change.composer/transcript/routes/inspector/Root keeps only the shell and cross-cutting files, plus every
package.jsonexport entry point (index.ts,designIcons.tsx,WorkbenchRoutes.tsx,hubDataMapping.ts,desktopChromeEvents.ts), so web/desktop imports are untouched.Relative imports were rewritten mechanically from git's rename data; the diff is 124 renames + import lines.
app/workbench/README.mdnow documents the layout.Also dropped
./shadcn/ai-elements/*from@agenthub/shared— it pointed at a directory that has never existed.Verification
tsc -bshared / workbench / web: clean.lint:cssclean; eslint 0 errors (pre-existing warnings only).visual:qa:shell4 shotsoverflow=false;visual:qa:chat16 shotsoverflow=false.