Repository navigation
chore(web): drop stale tasks-board visual QA script - #2393
Merged
Merged
Conversation
`visual-qa-tasks-board.mjs` hard-fails on master: it authenticates as a Hub user and then expects the fixture Kanban columns, but the Tasks page now renders the honest empty state in real-data mode, so `columns=[]` can never match. The script is not wired into CI, only into a `visual:qa:tasks-board` npm entry, and the Tasks shell is still covered by workbench tests. Removing the 150-line hand-written capture/gate instead of maintaining a second, drifting definition of the board contract. Co-authored-by: Codex <codex@delicious233.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app/web/scripts/visual-qa-tasks-board.mjshard-fails on master: it seeds a Hub session and then expects the fixture Kanban columns, while the Tasks page now renders the honest empty state in real-data mode (columns=[]by design). It is not wired into CI — only a manualvisual:qa:tasks-boardnpm entry.Removing the hand-written capture/gate rather than keeping a second, drifting definition of the Tasks board contract. Tasks shell coverage stays in
workbenchtests; shell/chat visual QA is unchanged.Verification
rg visual-qa-tasks-board→ no remaining referencespython scripts/verify/verify-doc-ssot.py→ okvisual:qa:shell/visual:qa:chatuntouched