Repository navigation
Add method to get centre of rotation by slice - #2376
Open
lauramurgatroyd wants to merge 4 commits into
Open
lauramurgatroyd wants to merge 4 commits into
lauramurgatroyd wants to merge 4 commits into
Conversation
Signed-off-by: Laura Murgatroyd <60604372+lauramurgatroyd@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Returns the centre of rotation offset for a given slice index.
This is useful if the axis is tilted
Open question - is it ok this just returns a float?
My thought was that we are only interested in the offset and the user will specify the index anyway.
get_centre_of_rotation returns a dict containing offset (value and unit), angle (value and unit). We could do this too to be consistent?
Example Usage
Contribution Notes
❤️ Thanks for your contribution!