Skip to content

Add correct geometry check to AcquisitionGeometry's _get_slice - #2378

Merged
lauramurgatroyd merged 3 commits into
masterfrom
geom_check_get_slice
Oct 23, 2026
Merged

lauramurgatroyd merged 3 commits into
masterfrom
geom_check_get_slice

Conversation

@lauramurgatroyd

@lauramurgatroyd lauramurgatroyd commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Description

Closes #2377

Example Usage

Contribution Notes

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

❤️ Thanks for your contribution!

Signed-off-by: Laura Murgatroyd <60604372+lauramurgatroyd@users.noreply.github.com>

@Neonbluestoplight Neonbluestoplight left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy fix and looks good to me!

@lauramurgatroyd
lauramurgatroyd merged commit b39f957 into master Oct 23, 2026
9 checks passed
@lauramurgatroyd
lauramurgatroyd deleted the geom_check_get_slice branch October 23, 2026 15:55
@github-project-automation github-project-automation Bot moved this from Todo to Done in CIL work Oct 23, 2026
@lauramurgatroyd lauramurgatroyd moved this from Done to Done & Reflected in CIL work Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done & Reflected

Development

Successfully merging this pull request may close these issues.

Acquisition Geometry's _get_slice doesn't check geometry types correctly

2 participants