Repository navigation
Conversation
paskino
force-pushed
the
remove-qdarkstyle
branch
from
October 26, 2026 16:33
972b104 to
f4ad884
Compare
delete workers that have finished to prevent destroy race conditions. This arose with pyside6 remove comment and use method for release payload added to changelog
paskino
force-pushed
the
remove-qdarkstyle
branch
from
October 26, 2026 17:01
f4ad884 to
e64f971
Compare
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A finished
Workeris released only when the nextWorkeris created, or never if no more are created.Before: Qt deleted the
QRunnableright after run() returned, on the pool thread leading to a segfault.Now: Qt never deletes it. Python keeps it in
_active_workersafterrun()sets_done = True. It is dropped from the main thread insideWorker.__init__, the next time any Worker is created. Memory is released by calling_release_payloadonce theWorkerhas finished (infinally, eg however it ends).At interpreter exit the leftover workers are cleaned up in the main thread, which is safe.