Conversation
Areloch
commented
Sep 13, 2026
Contributor
- Adjusted the handling for testing loading cached dts' and enumerating shape files in assetImport to more correctly and reliably populate shape contents for import
- Tweak to FrameTemp constructor so if FrameAllocator::alloc were to ever return NULL, have the size be appropriately 0 for better checks handling, rather than the assumed numElements size that failed
- Error check and handling in Stream::_read() so if the alloc fails, we can handle it and error log properly
- Tweaked logic in the tokenizer so we gate the quote token while loop as part of the loop argument, rather than internal to it to make it a bit cleaner and forces the assert to happen as an after-catch
- Have it so both GuiInspectorTypeRangedS32 and GuiInspectorTypeRangedF32 handle both altCommand and validate properly. As in, hitting enter validates the value as normal, but clicking off of the control and it losing focus now also validates the new value, so clicking away doesn't "lose" the change
- Added a sanity check to the renderProbeMgr's submitProbe
- Added a memcpy to the ambientChannels processing to minimize the chance of the memory being dropped once out of immediate scope
- When doing TSSkinMesh::createSkinBatchData(), tweaked the loop range to more correctly cap to BatchData::maxBonePerVert, rather than a potential overrun if batchOperations.last().transformCount ends up being bigger than it
…ng shape files in assetImport to more correctly and reliably populate shape contents for import - Tweak to FrameTemp constructor so if FrameAllocator::alloc were to ever return NULL, have the size be appropriately 0 for better checks handling, rather than the assumed numElements size that failed - Error check and handling in Stream::_read() so if the alloc fails, we can handle it and error log properly - Tweaked logic in the tokenizer so we gate the quote token while loop as part of the loop argument, rather than internal to it to make it a bit cleaner and forces the assert to happen as an after-catch - Have it so both GuiInspectorTypeRangedS32 and GuiInspectorTypeRangedF32 handle both altCommand and validate properly. As in, hitting enter validates the value as normal, but clicking off of the control and it losing focus now also validates the new value, so clicking away doesn't "lose" the change - Added a sanity check to the renderProbeMgr's submitProbe - Added a memcpy to the ambientChannels processing to minimize the chance of the memory being dropped once out of immediate scope - When doing TSSkinMesh::createSkinBatchData(), tweaked the loop range to more correctly cap to BatchData::maxBonePerVert, rather than a potential overrun if batchOperations.last().transformCount ends up being bigger than it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.