Skip to content

Refactor Redis container initialization and disposal in integration tests #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Phelecks merged 2 commits into from
Feb 7, 2026
Merged

Refactor Redis container initialization and disposal in integration tests #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdcabde
Refactor Redis container initialization and disposal in integration t…
Phelecks Feb 7, 2026
889225b
Remove redundant Redis connection disposal in integration tests teardown
Phelecks Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions tests/DistributedNonce.Tests/DistributedNonceIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,15 @@ public class DistributedNonceIntegrationTests
private IContainer? _redisContainer;
private const string RedisImage = "redis:latest";
private const int RedisPort = 6379;
private IConnectionMultiplexer? _mux;
private ConnectionMultiplexer? _mux;
private ServiceProvider? _provider;
private IClient _clientReturns5 = default!;
private IClient _clientReturns7 = default!;

[OneTimeSetUp]
public async Task OneTimeSetUp()
{
_redisContainer = new ContainerBuilder()
.WithImage(RedisImage)
_redisContainer = new ContainerBuilder(RedisImage)
.WithCleanUp(true)
.WithName($"dtm-redis-{Guid.NewGuid():N}")
.WithPortBinding(RedisPort, true)
Expand Down Expand Up @@ -76,7 +75,6 @@ public async Task OneTimeTearDown()
scope?.Dispose();
if (_provider is not null)
await _provider.DisposeAsync();
_mux?.Dispose();
}

[Test, Order(1)]
Expand Down