Skip to content

Dropped armv7 support in next variant - #487

Merged
acburdine merged 1 commit into
masterfrom
drop-armv7
Sep 10, 2026
Merged

Dropped armv7 support in next variant#487
acburdine merged 1 commit into
masterfrom
drop-armv7

Conversation

@acburdine

Copy link
Copy Markdown
Member

no ref

  • we'll want to drop armv7 support in Ghost 7 due to pnpm 12 not supporting it, so we'll update the next variant to match

no ref
- we'll want to drop armv7 support in Ghost 7 due to pnpm 12 not supporting it, so we'll update the next variant to match
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: d21dd7c7-0eaa-434b-a36e-7ae8ee94ff0b

📥 Commits

Reviewing files that changed from the base of the PR and between c6bb661 and 741f3d8.

📒 Files selected for processing (5)
  • 6-next/alpine3.23/Dockerfile
  • 6-next/bookworm/Dockerfile
  • Dockerfile-next.template
  • versions.json
  • versions.sh

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


Walkthrough

The Docker build definitions now use unconditional corepack enable, remove the pnpm failure override, and omit native build tools from non-Alpine installs. The next-image configuration removes pnpm fallback metadata and unsupported architectures. The image-generation script limits pnpm fallback data to regular images, removes arm32v7 next-image variants, and stops generating s390x sharp variants.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: ghost-slimer

Merge Risk: ⚪ Minimal · up to 741f3

The next image now targets amd64 and arm64v8 with matching package-manager and publication metadata changes. No merge-blocking production risk is evident.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: removing armv7 support from the next variant.
Description check ✅ Passed The description explains that the next variant drops armv7 support because pnpm 12 does not support armv7, which matches the pull request objectives and changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch drop-armv7

Comment @coderabbitai help to get the list of available commands.

@acburdine
acburdine merged commit bf283c3 into master Sep 10, 2026
9 checks passed
@acburdine
acburdine deleted the drop-armv7 branch September 10, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant