Skip to content

bootstrap-peers: add moonwake-ledger with a dialable p2p multiaddr - #498

Open
rapybus wants to merge 1 commit into
Twigpine:mainfrom
rapybus:patch-1
Open

rapybus wants to merge 1 commit into
Twigpine:mainfrom
rapybus:patch-1

Conversation

@rapybus

@rapybus rapybus commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Public node at https://node.moonwakeledger.com (v0.7.1, owner-only push,
reachable from node.gitlawb.com). Includes its libp2p QUIC address so new
nodes have a dialable seed for the DHT.

Summary by CodeRabbit

  • New Features

    • Added the Moonwake Ledger peer to the available peer list, including its connection details.
  • Updates

    • Refreshed the peer list’s update date to October 2, 2026.

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 7a3eb156-81c2-4899-a678-fd2bbc39e475

📥 Commits

Reviewing files that changed from the base of the PR and between bfc44f9 and b96d934.

📒 Files selected for processing (1)
  • bootstrap-peers.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The bootstrap peer seed list now has an updated date and includes a moonwake-ledger peer record with its operator, DID, HTTP URL, P2P multiaddress, and added date.

Changes

Bootstrap peer list

Layer / File(s) Summary
Update seed peer list
bootstrap-peers.json
The seed list’s updated date changed to 2026-10-02. A moonwake-ledger peer record was added with its operator, DID, HTTP URL, P2P multiaddress, and added date.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to b96d9

The new peer is included in the bootstrap inputs, and its endpoint formats match the inspected code paths. No concrete merge-blocking risk is established; live connectivity remains unverified.

Architecture Summary

Architecture risk: 🔵 Low · up to b96d9

The change affects 1 system.

Changed systems: bootstrap-peers.json

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — bootstrap-peers.json (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in bootstrap-peers.json: The seed list’s updated date changed from 2026-06-30 to 2026-10-02.
  • observed — Modified behavior in bootstrap-peers.json: Added the moonwake-ledger peer record with its operator, DID, HTTP URL, P2P multiaddress, and 2026-10-02 added date.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the node and the purpose of its libp2p address, but it does not follow the required template. It omits the Summary, Motivation & context, Kind of change, What changed, verific… Complete the required template. Add the change summary, motivation and issue reference, select the change type, list concrete changes, provide verification commands or steps, complete the pre-review checklist, and state whether the P2P addr…
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary change: adding the Moonwake Ledger bootstrap peer with a dialable P2P multiaddress.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the node and the purpose of its libp2p address, but it does not follow the required template. It omits the Summary, Motivation & context, Kind of change, What changed, verification steps, checklist status, and protocol impact sections.

Resolution

Complete the required template. Add the change summary, motivation and issue reference, select the change type, list concrete changes, provide verification commands or steps, complete the pre-review checklist, and state whether the P2P address affects protocol or wire formats.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🧪 Generate unit tests (beta)
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the needs-issue PR has no linked issue label Oct 2, 2026
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution. A couple of things will help us review this faster:

  • Link the issue this addresses (Closes #123). For protocol changes, open an issue first.

See CONTRIBUTING.md. Update the PR and these notes will clear automatically.

@beardthelion beardthelion left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read bootstrap-peers.json on origin/main (every p2p_multiaddr still null) and on this head (only moonwake-ledger has a dial field). I curled https://node.moonwakeledger.com/ and /ready: the live did and p2p_peer_id match the PR. I ran cargo test -p gitlawb-node --bin gitlawb-node bootstrap:: on head b96d934f; the bootstrap module tests passed. Fork CI: fmt, clippy, stable tests, release, MSRV, and Docker are green on https://github.com/Twigpine/node/actions/runs/36997602477; test (beta) is continue-on-error; cargo audit failed on that fork run while upstream main PR Checks is green, so I am not treating audit as introduced by this diff.

Findings

  • [P2] Keep p2p_multiaddr null until we publish first-party dial seeds
    bootstrap-peers.json:51
    On main, embedded seeds contribute zero libp2p dials; this row would be the fleet's first and only compile-time dial target for a third-party operator. HTTP listing is in policy (rapybus, #5); baking a /dns4/.../p2p/... into every binary is a network-ops admission call we have held on #297 for the same reason. Please set p2p_multiaddr to null, keep the http_url row, and use GITLAWB_P2P_BOOTSTRAP locally for dial experiments until we ship Gitlawb-operated dial multiaddrs or a written seed-operator bar.

  • [P2] Link a tracking issue in the PR body
    CONTRIBUTING.md / triage needs-issue label
    The PR has no Closes # / Fixes # reference and carries needs-issue. Open or link an issue that describes the public node listing request so triage can drop the label.

  • [P2] Use a conventional commit title before merge
    CONTRIBUTING.md:57, AGENTS.md:44
    Title and commit subject use bootstrap-peers:; the repo expects feat:, fix:, docs:, chore:, etc. A chore: subject for a seed-list update would match convention.

One process note, not a finding: expect a rebase conflict with #297 on bootstrap-peers.json; we are holding dial-field merges on both until policy flips, so coordinate so only one HTTP-only row lands first.

Not an ask, recorded only: embedded_seed_list_parses_successfully only calls parse_seed_list, not merge_into_vecs on the shipped file, so a bad multiaddr in JSON would stay green in CI until runtime skip. Worth a maintainer follow-up in bootstrap.rs, not a blocker on this JSON-only PR once p2p_multiaddr is null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-issue PR has no linked issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants