Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe bootstrap peer seed list now has an updated date and includes a moonwake-ledger peer record with its operator, DID, HTTP URL, P2P multiaddress, and added date. ChangesBootstrap peer list
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The new peer is included in the bootstrap inputs, and its endpoint formats match the inspected code paths. No concrete merge-blocking risk is established; live connectivity remains unverified. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the node and the purpose of its libp2p address, but it does not follow the required template. It omits the Summary, Motivation & context, Kind of change, What changed, verification steps, checklist status, and protocol impact sections. Resolution Complete the required template. Add the change summary, motivation and issue reference, select the change type, list concrete changes, provide verification commands or steps, complete the pre-review checklist, and state whether the P2P address affects protocol or wire formats.
✨ Finishing Touches 💡 1🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Comment |
|
Thanks for the contribution. A couple of things will help us review this faster:
See CONTRIBUTING.md. Update the PR and these notes will clear automatically. |
beardthelion
left a comment
There was a problem hiding this comment.
I read bootstrap-peers.json on origin/main (every p2p_multiaddr still null) and on this head (only moonwake-ledger has a dial field). I curled https://node.moonwakeledger.com/ and /ready: the live did and p2p_peer_id match the PR. I ran cargo test -p gitlawb-node --bin gitlawb-node bootstrap:: on head b96d934f; the bootstrap module tests passed. Fork CI: fmt, clippy, stable tests, release, MSRV, and Docker are green on https://github.com/Twigpine/node/actions/runs/36997602477; test (beta) is continue-on-error; cargo audit failed on that fork run while upstream main PR Checks is green, so I am not treating audit as introduced by this diff.
Findings
-
[P2] Keep
p2p_multiaddrnull until we publish first-party dial seeds
bootstrap-peers.json:51
Onmain, embedded seeds contribute zero libp2p dials; this row would be the fleet's first and only compile-time dial target for a third-party operator. HTTP listing is in policy (rapybus, #5); baking a/dns4/.../p2p/...into every binary is a network-ops admission call we have held on #297 for the same reason. Please setp2p_multiaddrtonull, keep thehttp_urlrow, and useGITLAWB_P2P_BOOTSTRAPlocally for dial experiments until we ship Gitlawb-operated dial multiaddrs or a written seed-operator bar. -
[P2] Link a tracking issue in the PR body
CONTRIBUTING.md/ triageneeds-issuelabel
The PR has noCloses #/Fixes #reference and carriesneeds-issue. Open or link an issue that describes the public node listing request so triage can drop the label. -
[P2] Use a conventional commit title before merge
CONTRIBUTING.md:57,AGENTS.md:44
Title and commit subject usebootstrap-peers:; the repo expectsfeat:,fix:,docs:,chore:, etc. Achore:subject for a seed-list update would match convention.
One process note, not a finding: expect a rebase conflict with #297 on bootstrap-peers.json; we are holding dial-field merges on both until policy flips, so coordinate so only one HTTP-only row lands first.
Not an ask, recorded only: embedded_seed_list_parses_successfully only calls parse_seed_list, not merge_into_vecs on the shipped file, so a bad multiaddr in JSON would stay green in CI until runtime skip. Worth a maintainer follow-up in bootstrap.rs, not a blocker on this JSON-only PR once p2p_multiaddr is null.
Public node at https://node.moonwakeledger.com (v0.7.1, owner-only push,
reachable from node.gitlawb.com). Includes its libp2p QUIC address so new
nodes have a dialable seed for the DHT.
Summary by CodeRabbit
New Features
Updates