Skip to content

CI never runs the race detector #1102

Description

@PierrunoYT

Found in the 2026-09-28 code audit (finding N-7).

Where: .github/workflows/ci.yml:79, release-artifacts.yml:51, pr-auto-review.yml:42 all run plain go test ./.... Makefile:20-22 claims -race "matches CI expectations".

Problem: 41 *Race* / *Concurrent* tests exist and several only pay off under -race: internal/daemon/session_race_test.go:14, internal/execution/process_manager_test.go:248, internal/notify/notify_test.go:101,233, internal/tools/capabilities_test.go:397, internal/tools/plan_tool_test.go:199. Without -race they pass regardless. AGENTS.md also asks for concurrent code to run under the race detector.

Suggested fix: add -race to at least the ubuntu leg (Windows runners ship mingw, so Windows too) and correct the Makefile comment.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions