Repository navigation

Auto-generate Omeka site permissions from Teams role assignments - #199

Merged

alexdryden merged 54 commits into

copilot/fix-issue-189

Sep 11, 2026

Commits on Aug 10, 2026

Add SitePermissionManager service and wire issue #189 triggers

Copilot
and
alexdryden
authored
ed8cfe6
Remove docs/service-layer-pattern.md (rationale kept in chat only)

Copilot
and
alexdryden
authored
38b8fa5
Apply remaining changes

Copilot
and
alexdryden
authored
105169b
fix: sync site permissions when team member roles are changed or removed via teamUpdateAction

Copilot
and
alexdryden
authored
2c0ed29
fix: map can_add_site_pages to ROLE_MANAGER (not ROLE_ADMIN) and ROLE_VIEWER

Copilot
and
alexdryden
authored
26bde25
feat: site admin UI warning and team attribution; fix removal logic to compare team roles not site roles

Copilot
and
alexdryden
authored
2ec5bbc
Fix upgrade: require_once SitePermissionManager before direct instantiation

Copilot
and
alexdryden
authored
ee7d715
Remove syncAllSitePermissions from upgrade; expose as config form button

Copilot
and
alexdryden
authored
f90a766
Fix ROLE_ADMIN constant, remove exclusion logic, update sync language

Copilot
and
alexdryden
authored
c322631
Fix ROLE_ADMIN constant, remove exclusion logic, update language to reflect syncing

Copilot
and
alexdryden
authored
93ec134
Refresh TeamUser entity in syncSitePermissionsForUser to fix stale role on elevation

Copilot
and
alexdryden
authored
565999c
Use syncAllSitePermissions at end of team edit, matching sync button behavior exactly

Copilot
and
alexdryden
authored
cb06e0a
fix: only use the sync method
alexdryden
committed
b699f7c
fix: return the devolop version and just add a single sync all
alexdryden
committed
90793c0
fix: single sync at the end
alexdryden
committed
a5b0765
fix: restore to pre feat state
alexdryden
committed
eb4c007
fix: single sync at the end
alexdryden
committed
2c4bea1

Commits on Aug 11, 2026

fix: add logging
alexdryden
committed
ebe86eb
Add detailed debug logging and fix $omekaRole typo in SitePermissionManager

Copilot
and
alexdryden
authored
29682df
Fix Logger type hint: use Laminas\Log\Logger instead of controller plugin

Copilot
and
alexdryden
authored
a060432
chore: detailed logging
alexdryden
committed
759efcc
fix: typo
alexdryden
committed
9a0a4e8
fix: typo
alexdryden
committed
ff455a5
Fix partial DQL polluting TeamRole identity map with incomplete entities

Copilot
and
alexdryden
authored
5fcd49a
refactor: old, weird code with api calls mostly
alexdryden
committed
0980830
Refactor controllers to use API; clean up dead imports and dead code

Copilot
and
alexdryden
authored
75e6cd9
Fix review issues: logging level, unused var, XSS protection in inline scripts

Copilot
and
alexdryden
authored
84dfaa5
Fix validateRequest to handle UPDATE operation in AbstractTeamEntityAdapter

Copilot
and
alexdryden
authored
b6f5f83
Remove userAction/route/TeamCompactForm; use API for team-site; refactor sites form; replace JS annotation with PHP HTML

Copilot
and
alexdryden
authored
7e551a7
fix: role edits, team-site domain error, null sites crash, and users page team info

Copilot
and
alexdryden
authored
c7b7a24
fix: show warning banner only when teams actually manage users on the site

Copilot
and
alexdryden
authored
36d2d89
fix: normalise team/user keys before validation in AbstractTeamEntityAdapter

Copilot
and
alexdryden
authored
c535a9b
Clean up change-referencing comments; keep only code-explaining comments

Copilot
and
alexdryden
authored
f7979e6
Fix PHP parse errors: remove duplicate code in TeamForm.php and UpdateController.php

Copilot
and
alexdryden
authored
ad77ff2
Fix addCsrf() call, Containerinterface typo, remove unused import; update linting instructions

Copilot
and
alexdryden
authored
b4eb6f4
chore: planning full team add/edit refactor

Copilot
and
alexdryden
authored
86247e4
Apply remaining changes

Copilot
and
alexdryden
authored
c2b7310
fix: restore TeamSitesAddRemoveForm to extend Form so prepare() works

Copilot
and
alexdryden
authored
3657935

Commits on Aug 12, 2026

fix: remove unused setData() call on SecondaryResourcesForm (Fieldset)

Copilot
and
alexdryden
authored
880b045
refactor: follow Omeka S form pattern for team add/edit pages

Copilot
and
alexdryden
authored
d13bb63
Fix role assignment bug, teams column, deprecation warning, and consolidate TeamForm

Copilot
and
alexdryden
authored
bb2889c
fix: add allow empty for select fields
alexdryden
committed
a2b1567
fix: normalize team_sites field name and fix o:site allow_empty validation

Copilot
and
alexdryden
authored
b0d0f46
fix: replace TeamSitesFieldset with direct AllSiteSelect on TeamForm; remove dead form classes

Copilot
and
alexdryden
authored
4bb1ec8
fix: restore chosen-select class to sites
alexdryden
committed
4ce1a5b
Apply remaining changes

Copilot
and
alexdryden
authored
4d33a40
fix: replace nested API calls in hydrate with direct EM ops; fix undefined $entity in TeamResourceAdapter::delete

Copilot
and
alexdryden
authored
398854b
Fix DQL reserved keyword 'is' alias and item-set-only filtering in TeamAdapter

Copilot
and
alexdryden
authored
227749c
Fix deselection of item sets and resource templates in team form JS

Copilot
and
alexdryden
authored
0c8ce25
Replace syncAllSitePermissions with targeted sync calls in UpdateController

Copilot
and
alexdryden
authored
7a17b86
refactor: move site-permission sync into TeamUserAdapter and TeamSiteAdapter

Copilot
and
alexdryden
authored
96ea4d2
Fix three site permission bugs: remove uses stale TeamSite row, sync uses highest role, name display injected directly

Copilot
and
alexdryden
authored
c357dfa
Refactor SitePermissionManager to use API; build template rows server-side

Copilot
and
alexdryden
authored
059a2b1
Use real PHP loop indices in rendered permission rows

Copilot
and
alexdryden
authored
4af3fc7