Repository navigation
[FIX] 포커스 종료 시 클라이언트 집중 시간(durationSec) 반영 - #380
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (11)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. Walkthrough포커스 종료 요청에 선택 필드 Changes포커스 종료 시간 계산
서재 최근 포커스 조회
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change adds an optional durationSec to focus end requests and makes the recent-focus response use the latest ended focus. No concrete merge-blocking risk was identified. Note that focusTime reports today's time rather than the cumulative time requested in the linked issue. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)✅ Passed checks (3 passed)Full details: Linked Issues checkExplanation 직접 연결된 [ Full details: Docstring CoverageExplanation Docstring coverage is 5.41% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 37 functions across 9 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 당근 든 토끼가 시간을 세어요 Comment |
|
📄 작업 내용 요약
GET /api/v1/library/recent-focus) 응답 기준 수정endedAtnot null) 가장 최근 포커스 기준으로 조회 (진행 중 포커스 제외)focusTime: 해당 책의 오늘 포커스 시간 (포커스 홈 책별todayFocusTime과 같은 기준, 자정 초기화, 오늘 기록 없으면00:00:00)page: 그 포커스 종료 시 입력한endPage(미입력 시null)FINISHED)이면result: null(다른 책으로 대체하지 않음)POST /api/v1/focuses/end)에 선택 필드durationSec(초) 추가0 ≤ durationSec ≤ 서버 계산 경과 시간으로 보정, 종료 시각 =startedAt + durationSec📎 Issue 번호
✅ 작업 목록
Summary by CodeRabbit
00:00:00으로 표시합니다.