Repository navigation
fix(firered): match bag, item PC, and field UI - #72
Merged
UNDERdecoded merged 3 commits intoOct 19, 2026
Merged
Conversation
Font.lua: keep this PR's prepareFrameStrip/drawDialogueRecord split and add main's Font.dialogueBoxBounds alongside it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Gen3ItemPcQuantity: keep the Deposit/Withdraw verb and dark style, add main's strings-gate marker on the line-break glue. Gen3PlayerPC: route the withdrew fallback through Strings() so gate_strings_coverage passes. RomImporter: v367 for this PR's extraction on top of main's v366. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
RESULT pass=24 fail=0git diff --checkclean before commitrom-cache-v365Stacking
This branch is based on the still-open #71 (
firered-visual-bugs-02), so GitHub will temporarily show those earlier commits in this PR until #71 merges.