Skip to content

Blank only test items in RT-04 source scanner (#169) - #173

Closed
afflom wants to merge 1 commit into
mainfrom
issue-169-rt04-cfg-test
Closed

afflom wants to merge 1 commit into
mainfrom
issue-169-rt04-cfg-test

Conversation

@afflom

@afflom afflom commented Oct 18, 2026

Copy link
Copy Markdown
Member

Closes #169

Summary

  • Updates without_test_items in crates/conformance/src/cases/runtime.rs so that:
    • #![cfg(test)] blanks the whole file only when it appears as one of the file's leading inner attributes before any item (and never when it appears inside an inline mod m { #![cfg(test)] }).
    • #[cfg(test)] blanks only when, after any further outer attributes (#[...]), optional visibility (pub, pub(...)), and item modifiers, it is followed by an item keyword (mod, fn, use, impl, const, static, struct, enum, union, type, trait, extern, macro_rules!), and never blanks production code after a #[cfg(test)] on a struct field, enum variant, function parameter, or match arm.
    • Also includes the scanner hardening from the fix(#154): the runtime gates read what they claim to #156 review (cr"..." raw C strings, comment-blanked literal gaps in runtime_texts, inline Lean comments/set_option ... in before declaration keywords, and _root_. / guillemets in declares_under_runtime).
  • Plants all five non-item #[cfg(test)] / inline #![cfg(test)] shapes and + string concatenation in rt_04, and records the planted defect output in VERIFICATION.md and CHANGELOG.md.
  • Touches no files in SEMANTIC_DIRS and changes no diagnostic code or conformance ID.

@afflom
afflom marked this pull request as ready for review October 18, 2026 04:27
@afflom

afflom commented Oct 18, 2026

Copy link
Copy Markdown
Member Author

@afflom @humuhumu33 Ready for review.

@afflom
afflom marked this pull request as draft October 18, 2026 04:33
@afflom
afflom marked this pull request as ready for review October 18, 2026 04:34
@afflom

afflom commented Oct 18, 2026 •

Copy link
Copy Markdown
Member Author

@afflom @humuhumu33 Full ready-for-review gate run 39097581738 is 25/25 green (honesty and reproducibility also green: 27/27 checks passed) on b3a0d981e, which contains main (8765feea3) and touches nothing in SEMANTIC_DIRS.

@afflom

afflom commented Oct 18, 2026

Copy link
Copy Markdown
Member Author

Rebased onto main (193cd2148) at 6a8c5b56d, removing the stray BS-02 CHANGELOG bullet that conflicted with main, and verified cargo xtask validate, conformance_rt_04, and conformance_rp_08 locally. cc @afflom @humuhumu33

@afflom

afflom commented Oct 18, 2026

Copy link
Copy Markdown
Member Author

@afflom @humuhumu33 Full ready-for-review gate run 39113611038 is 25/25 green (honesty and reproducibility also green: 27/27 checks passed, mergeStateStatus: CLEAN) on 6a8c5b56d, which contains main (193cd2148) and touches nothing in SEMANTIC_DIRS.

afflom added a commit that referenced this pull request Oct 18, 2026
#173 (#169) and #174 (#170) (#171)

Closes #169
Closes #170
Refs #92

BS-02 (TokenAudit as language-1.2 source, lex and auditTokens as rust-std roots held to production::preserve), #173 (RT-04 scanner blanks only test items), #174 (tracked tree holds nothing the walkers skip). Register 414. Gate: run 39125361480 on 1df1b9f, 25/25 green. Merged by the maintainer on the owner's rule: green gate and the linked issues' DoD met.

afflom commented Oct 18, 2026

Copy link
Copy Markdown
Member Author

Landed through wave 2, #171, merged to main as d51d9f223: this branch's head 1cc1ab1cc (the #169 fix on top of main) is merged into that PR unchanged, so its commit is in main's history and #169 is closed by the merge. Closing this PR by hand; its gate ran as part of #171's run 39125361480.


Generated by Claude Code

@afflom afflom closed this Oct 18, 2026
humuhumu33 added a commit that referenced this pull request Oct 18, 2026
…0-slice2

The merged tree is main plus the slice-2 sources; generated records are
regenerated next. Main moved no version field since 193cd21, so the
combined semantic_ir 14, lean_backend 20, latex_backend 13 stand. The
register is 414 on main plus LM-04..LM-06: 417, set by hand in README, the
SPEC §31 total, repository.rs and spec_links.rs. CHANGELOG keeps both
entries.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v0.4] RT-04: blank only test items, never the code after a cfg(test) that is not on an item (follow-up to #156)

1 participant