276 implement zbkb - #282
Open
Waffles3438 wants to merge 13 commits into
Open
Conversation
implemented zbkb using zbb as reference. not tested, but had claude check over everything
kept original variable names, using a, b and out
Open
🔧 DE1-SoC Synthesis Report Summary Diff
Comparing synthesis results from main branch vs. this PR |
| B_ALU_CTRL__ROL: out = get_rol(a, b[SHIFT_WIDTH - 1:0]); // rol (rotate left) | ||
| B_ALU_CTRL__ROR: out = get_ror(a, b[SHIFT_WIDTH - 1:0]); // ror (rotate right) | ||
| B_ALU_CTRL__RORI: out = get_ror(a, b[SHIFT_WIDTH - 1:0]); // rori (rotate right immediate) | ||
| B_ALU_CTRL__ANDN: out = a & ~b; // andn |
Member
There was a problem hiding this comment.
this is kind of an interesting case since i think another Zbb also has this function. I think right now we are not differentiating between extensions when enabling them but might need to revisit this later
Author
There was a problem hiding this comment.
i got these from zbb, since zbkb needs then, should i remove them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implemented zbkb
created, ran and passes all tests
also made it so every branch can use actions, not just main
im so sorry for all the prs 😭