Update printer linter to utilize the reusable action - #21657
Draft
HellAholic wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the GitHub Actions workflow for the printer linter PR diagnose job. The main change is switching from a third-party diff action to a custom action, with adjustments to how file patterns are specified and how outputs are consumed in subsequent steps.
Workflow action updates:
greguintow/get-diff-actionwith a customultimaker/cura-workflows/.github/actions/get-diffaction, updating the input parameters to use explicit file globs and including deleted files.Job step improvements:
get-diffaction, ensuring only relevant files are processed and improving reliability.Requires: Ultimaker/cura-workflows#54
CURA-13207