fix: make keymap SVG keys findable with VoiceOver - #3054
Open
mondalaci wants to merge 2 commits into
Open
Conversation
Name keys by physical QWERTY position plus current mapping, and hide off-screen layers and the remap overlay from the accessibility tree so icon-only and unmapped keys remain searchable. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Up Arrow,Up Arrow, unassigned,I, Up Arrow) so VoiceOver can find icon-only and empty keys.aria-label, an SVG<title>, and a near-invisible<text>node; VoiceOver often ignoresaria-labelon SVG<g>and skips keys that have no text.This is the Agent-side fix for a VoiceOver user who could not locate Mod-layer arrow keys: Home/End have text captions, arrows are icons, and unmapped keys previously had no usable name.
Test plan
arrowfinds the four physical arrow keys.arrowstill finds the letter-row Up key (I, Up Arrowor similar) and the physical up-arrow (Up Arrow, unassigned).Made with Cursor